Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autoreject duplicate results #24

Open
obbardc opened this issue Jul 24, 2024 · 2 comments
Open

Autoreject duplicate results #24

obbardc opened this issue Jul 24, 2024 · 2 comments

Comments

@obbardc
Copy link
Contributor

obbardc commented Jul 24, 2024

For pull requests which have the same results (e.g UUID in the filename) as existing results in the database, we should close PRs and issues.

@htejun is UUID in filename a suitable collision detection method?

In this case, rejection really means closing of issue, PR , deletion of files in bucket & branches.

Possibly there could be a nightly CI run which triggers this.

@htejun
Copy link

htejun commented Jul 24, 2024

I don't know where there UUID in the filename is coming from. I think it might make sense to add a signature in the result json file itself for reliable detection - ie. let the json file carry its own signature as its ID. What do you think?

@obbardc
Copy link
Contributor Author

obbardc commented Jul 24, 2024

Looks like that md5sum is currently the md5sum of the uploaded data. we can initially reject on that, before even processing the result.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

2 participants