Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rct to 1.2.7 #3587

Closed
wants to merge 1 commit into from
Closed

Update rct to 1.2.7 #3587

wants to merge 1 commit into from

Conversation

NCIceWolf
Copy link

@NCIceWolf NCIceWolf commented May 7, 2024

Please update stable version of ioBroker.rct from 1.2.4 to 1.2.7

Changelog:
1.2.7 (2024-05-05)
(Andreas Ruttkamp) prim_sm.state added
(NCIceWolf) handling of type errors added
(Andreas Ruttkamp) some Code cleaning
(NCIceWolf) Update io-package.json

1.2.6 (2024-05-03)
(Andreas Ruttkamp) unused parameter deleted

1.2.5 (2024-05-02)
(Andreas Ruttkamp) misspelling in rct_core2 corrected
(Andreas Ruttkamp) Missing ack:true added
(Andreas Ruttkamp) datatypes corrected
(NCIceWolf) changes to correct loosing connection

1.2.7 (2024-05-05)
(Andreas Ruttkamp) prim_sm.state added
(NCIceWolf) handling of type errors added
(Andreas Ruttkamp) some Code cleaning
(NCIceWolf) Update io-package.json

1.2.6 (2024-05-03)
(Andreas Ruttkamp) unused parameter deleted

1.2.5 (2024-05-02)
(Andreas Ruttkamp) misspelling in rct_core2 corrected
(Andreas Ruttkamp) Missing ack:true added ( issue:#89)
(Andreas Ruttkamp) datatypes corrected ( issue:#106)
(NCIceWolf) changes to correct loosing connection ( issue:#114 )
@github-actions github-actions bot added Stable auto-checked This PR was automatically checked for obvious criterias labels May 7, 2024
@NCIceWolf NCIceWolf changed the title Update stable version in repo from 1.2.4 to 1.2.7 Update rct to 1.2.7 May 7, 2024
Copy link

github-actions bot commented May 7, 2024

Automated adapter checker

ioBroker.rct

Downloads Number of Installations (latest) Number of Installations (stable) - Test and Release
NPM

👍 No errors found

  • 👀 [W156] Adapter should support admin 5 UI (jsonConfig) if you do not use a React based UI
  • 👀 [W184] "common.materialize" is deprecated for admin >= 5 at io-package.json. Please use property "adminUI".

Adapter releases: https://www.iobroker.dev/adapter/rct/releases
Adapter statistic: https://www.iobroker.dev/adapter/rct/statistics

History and usage information for release 1.2.7:

1.2.7 created 5.5.2024 (1 days old)
13 users (5.91%)

1.2.4 (stable) created 9.2.2024 (87 days old)
141 users (stable) (64.09%)

Please verify that this PR really tries to update to release 1.2.7!

Add comment "RE-CHECK!" to start check anew

@mcm1957
Copy link
Collaborator

mcm1957 commented May 7, 2024

@aruttkamp
Is this update requested by you?
Did you authorize @NCIceWolf to request an update?

@mcm1957 mcm1957 added ON HOLD PR is set ON HOLD due to pending question or major issues. STABLE - brand new This PR for stable has been created before release was available at latest for min 7 days labels May 7, 2024
@aruttkamp
Copy link
Contributor

@mcm1957

Is this update requested by you?
No
I think we should wait minimum 7 days. Actually its 2 days old and we have no issues ....

@github-actions github-actions bot added the *📬 a new comment has been added label May 7, 2024
@mcm1957
Copy link
Collaborator

mcm1957 commented May 7, 2024

OK, 1 week minimum time at latest will be enforced by me anyway unless there is not hot-fix requested. See tagging.

The main goal of my comment was to check whether this PR is authorized by you as the repoowner differs from issuer of PR and this repo is not part of a organization. If I read your answer correctly this PR has not been dsicussed before creation. As it is a little bit early too I will close it for now. Please create a new PR as soon as you think your version is ready for stable.

@mcm1957 mcm1957 closed this May 7, 2024
@mcm1957 mcm1957 added invalid and removed ON HOLD PR is set ON HOLD due to pending question or major issues. *📬 a new comment has been added STABLE - brand new This PR for stable has been created before release was available at latest for min 7 days labels May 7, 2024
@NCIceWolf
Copy link
Author

Hey guys!
Wasn't my intention to cause any misunderstandings here, I believed this PR to reach @aruttkamp for approval anyway.
I did not flag it as hot fix, yet it practically is one.
Version 1.2.4 has communication issues with the inverter since the vendor changed something on their end on 24.04.2024, so a version >1.2.4 is needed for correct operation.
I just wanted to make sure all “stable-users” get this fix rather sooner than later.

@github-actions github-actions bot added the *📬 a new comment has been added label May 8, 2024
@mcm1957
Copy link
Collaborator

mcm1957 commented May 8, 2024

Hi, @NCIceWolf ,
thanks for feedback. And MANY THANKS for working at an adapter usn supporting ioBroker.

From time to time some users request repository updates although they are not involved in the adapter development. This is most likely done with very good targets, but releasing should be controlled by maintainers only. So I always ask the repo owner / known maintainer to confirm if such a request is ok, espscially if the requesting user is new. I do not have the possibility to check access rights at foreign repositories so I cannot check if a user requesing a PR has at least write access or een admin acccess to a repo. Sorry if this blocks sometimes. And thats absolutly no critic at you. In opposite: Thanks for helping and supporting.

If an urgent update is required due to changes at provider site this is classic reason for a hotfix / fast lane request. I tried to reopen this PR but the repo behind this PR was already deleted so I cannot do this anymore.

@aruttkamp
Please create a PR as soon as you want a newer version be released to stable (or comment her, then I can do this too if you temporary do not have access to a system to do so.

@aruttkamp
Copy link
Contributor

@mcm1957
PR #3592 created.

@mcm1957 mcm1957 mentioned this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
*📬 a new comment has been added auto-checked This PR was automatically checked for obvious criterias invalid Stable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants