Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error assembling JAR: Manifest file does exist #51

Open
abroekhuis opened this issue Nov 18, 2020 · 1 comment
Open

Error assembling JAR: Manifest file does exist #51

abroekhuis opened this issue Nov 18, 2020 · 1 comment
Labels

Comments

@abroekhuis
Copy link

Not a bug, more a remark on the blog post at https://blog.io7m.com/2019/05/16/instant-code-reloading.xhtml

In this post you refer to the un-existing manifest file in a parent pom. Instead of creating this file, it is also possible to setup the jar plugin and add the skipIfEmpty configuration to the execution.

<execution> <id>jar</id> <goals> <goal>jar</goal> </goals> <configuration> <skipIfEmpty>true</skipIfEmpty> </configuration> </execution>

@io7m
Copy link
Member

io7m commented Apr 4, 2021

Hello! Just noticing this ticket today. Sorry for the delay!

It's certainly possible to do that, but I'd personally avoid it because creating an empty jar file is something you'd normally want to prevent in a build. As I mentioned in the blog:

I strongly recommend not doing this as part of the actual Maven build itself; this is something that's only needed by developers who are making use of this live code updating setup during development, and isn't something that the Maven build needs to know about. By executing specific plugins, we're not calling Maven in the way that it would normally be called and therefore it's up to us to ensure that things are set up correctly so that the plugins can work.

@io7m io7m added the wontfix label Dec 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants