From fc3cade6decfd030d6c1a78597aad3a88ddd5a9d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Luismi=20Cavall=C3=A9?= <luismi@lmcavalle.com>
Date: Fri, 18 Oct 2024 13:05:59 +0000
Subject: [PATCH 1/2] Add extension for EsigibilitaIVA to it-sdi addon

---
 CHANGELOG.md                |  5 +++--
 addons/it/sdi/extensions.go | 35 ++++++++++++++++++++++++++++++++---
 2 files changed, 35 insertions(+), 5 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 55b5b25c..8bea51af 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -8,11 +8,12 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/) and this p
 
 ### Added
 
-- `uuid` - SQL library compatibility for type conversion.
+- `uuid`: SQL library compatibility for type conversion.
+- `it-sdi-v1`: added `it-sdi-vat-collect` extension for EsigibilitaIVA.
 
 ### Fixed
 
-- `bill.Invoice` - remove empty taxes instances.
+- `bill.Invoice`: remove empty taxes instances.
 
 ## [v0.202.0]
 
diff --git a/addons/it/sdi/extensions.go b/addons/it/sdi/extensions.go
index d7ec0ab4..34602bb3 100644
--- a/addons/it/sdi/extensions.go
+++ b/addons/it/sdi/extensions.go
@@ -15,6 +15,7 @@ const (
 	ExtKeyExempt       cbc.Key = "it-sdi-exempt"
 	ExtKeyRetained     cbc.Key = "it-sdi-retained"
 	ExtKeyPaymentMeans cbc.Key = "it-sdi-payment-means"
+	ExtKeyVATCollect   cbc.Key = "it-sdi-vat-collect"
 )
 
 var extensions = []*cbc.KeyDefinition{
@@ -29,7 +30,7 @@ var extensions = []*cbc.KeyDefinition{
 				Code used to describe the transmission format of the invoice. By default
 				the value "FPR12" is used unless the user explicitly sets the value
 				to something else.
-				
+
 				Normally this will only be needed when the invoice is to be sent to governmental
 				bodies and must use the "FPA12" format.
 			`),
@@ -458,7 +459,6 @@ var extensions = []*cbc.KeyDefinition{
 			},
 		},
 	},
-
 	{
 		// Retained reason code determined from the "CausalePagamento" field from FatturaPA.
 		// Source: https://www.agenziaentrate.gov.it/portale/documents/20143/4115385/CU_istr_2022.pdf
@@ -695,7 +695,6 @@ var extensions = []*cbc.KeyDefinition{
 			},
 		},
 	},
-
 	{
 		Key: ExtKeyPaymentMeans,
 		Name: i18n.String{
@@ -866,4 +865,34 @@ var extensions = []*cbc.KeyDefinition{
 			},
 		},
 	},
+	{
+		Key: ExtKeyVATCollect,
+		Name: i18n.String{
+			i18n.EN: "VAT Collection",
+			i18n.IT: "Esigibilità dell'IVA",
+		},
+		Values: []*cbc.ValueDefinition{
+			{
+				Value: "I",
+				Name: i18n.String{
+					i18n.EN: "Immediate",
+					i18n.IT: "Immediata",
+				},
+			},
+			{
+				Value: "D",
+				Name: i18n.String{
+					i18n.EN: "Deferred",
+					i18n.IT: "Differita",
+				},
+			},
+			{
+				Value: "S",
+				Name: i18n.String{
+					i18n.EN: "Split Payment",
+					i18n.IT: "Scissione dei pagamenti",
+				},
+			},
+		},
+	},
 }

From 7b87944f216150fd69016855e47980508422601d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Luismi=20Cavall=C3=A9?= <luismi@lmcavalle.com>
Date: Mon, 21 Oct 2024 15:29:20 +0000
Subject: [PATCH 2/2] Avoid verb in name

---
 addons/it/sdi/extensions.go | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/addons/it/sdi/extensions.go b/addons/it/sdi/extensions.go
index 34602bb3..8fd6ec9f 100644
--- a/addons/it/sdi/extensions.go
+++ b/addons/it/sdi/extensions.go
@@ -15,7 +15,7 @@ const (
 	ExtKeyExempt       cbc.Key = "it-sdi-exempt"
 	ExtKeyRetained     cbc.Key = "it-sdi-retained"
 	ExtKeyPaymentMeans cbc.Key = "it-sdi-payment-means"
-	ExtKeyVATCollect   cbc.Key = "it-sdi-vat-collect"
+	ExtKeyVATLiability cbc.Key = "it-sdi-vat-liability"
 )
 
 var extensions = []*cbc.KeyDefinition{
@@ -866,9 +866,9 @@ var extensions = []*cbc.KeyDefinition{
 		},
 	},
 	{
-		Key: ExtKeyVATCollect,
+		Key: ExtKeyVATLiability,
 		Name: i18n.String{
-			i18n.EN: "VAT Collection",
+			i18n.EN: "VAT Liability",
 			i18n.IT: "Esigibilità dell'IVA",
 		},
 		Values: []*cbc.ValueDefinition{