-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New architecture support (status: v9.1.4 should work, headlessJS requires react-native 0.76.5+ for old architecture) #1077
Comments
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as outdated.
This comment was marked as outdated.
Just chatted with the ever-benevolent (I mean that!) overlords @ Invertase and I can check this repo for RN76 compat, so I'll have a go myself but I will always welcome information + help + advice from anyone else so please chime in if you are reading this and you're looking at it too. Hopefully it's easy! |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This is supposed to be fixed in react-native 0.76.1, it needs a retest to see if background handling works again with new architecture. It may take me some time to get a suitable reproduction environment set up and I would welcome anyone to post success or failure on 0.76.1 if they are able to test this before I get to it. |
I've just upgraded to 0.76.1 and foreground service does not work with new arch. It works while the app is opened, but gets stuck if I close it. No error messages, I haven't digged it up. |
That's surprising! That's worse than I was hoping to hear 😆 . I want to put a sad face or a thumbs-down reaction on your comment but it's the content, not for you as a messenger of course @netdown. Were you able to test if headlessJS works? As that is a separate issue from foreground service I'll add foreground service testing to the status list above. |
I use foreground service only. |
Same issue @netdown my foreground service freezes completely on new architecture once the app is out of focus |
i have a better understanding of the issue i had - setTimeout will cause problems when app is minimized and resumed, as clearFrameCallback will only be called when there is no active headlessJsTask, and setTimeout lingering will simply fail after onHostResume it seems like. I have no idea why it worked with the old arch. and if I apply my "patch", all setTimeout will stop to function when app is minimized. Since whatwg-fetch uses a setTimeout with xhr.onLoad, it "breaks." |
@lovegaoshi definitely interested and I read through the related information from RNTP with great interest earlier, I appreciate the cross-posting an the work you've put in to making headlessJS work on Fabric so far! Hopefully we all get through this in once piece 😆 |
@mikehardy Foreground service seems to be fine in 0.76.2! Probably fixed by facebook/react-native@ee7b4e2 |
Fantastic news! Now we just need background messages to work correctly per the latest one facebook/react-native#47570 We're getting there, bit by bit... |
react-native 0.76.5 should work with Notifee 9.1.4+ in either old architecture or new architecture mode Been quite the battle getting there! We may still have issues, there are reports of issues still but nothing I can pin down with Notifee stack traces yet so I'm going to close this as to the best of my knowledge I can say "Notifee works with react-native 0.76 in old or new architecture" Hopefully I will not have to reopen it 😅 |
Discussed in #795
Originally posted by ravindraguptacapgemini June 13, 2023
Need to know if library support new architecture of React Native with Fabric and Turbo Module.
Currently this module will not work with react-native in new architecture mode, bridgeless or otherwise.
The first step is to get it working in bridgeless mode at minimum. These issues block that:
Update status here when complete: https://reactnative.directory/?search=%40notifee%2Freact-native
The text was updated successfully, but these errors were encountered: