From a4f50b76714df974228c2400eaa80356f6903ee3 Mon Sep 17 00:00:00 2001
From: Mike Hardy <github@mikehardy.net>
Date: Tue, 12 Dec 2023 20:32:55 -0500
Subject: [PATCH] test(ci): use node v18, JDK17, xcode-latest, macos-12 in CI

more modern toolchains - only avoiding macos-13+xcode-15 because
the iOS performance is so terrible there
---
 .github/workflows/linting.yml           |  6 +++---
 .github/workflows/tests_e2e_android.yml | 16 +++++-----------
 .github/workflows/tests_e2e_ios.yml     |  8 ++++----
 .github/workflows/tests_jest.yml        |  2 +-
 .github/workflows/tests_junit.yml       | 14 ++++----------
 5 files changed, 17 insertions(+), 29 deletions(-)

diff --git a/.github/workflows/linting.yml b/.github/workflows/linting.yml
index 033e8fe8..06d83cd7 100644
--- a/.github/workflows/linting.yml
+++ b/.github/workflows/linting.yml
@@ -20,7 +20,7 @@ jobs:
           submodules: recursive
       - uses: actions/setup-node@v2
         with:
-          node-version: '14'
+          node-version: 18
       - name: Get yarn cache directory path
         id: yarn-cache-dir-path
         run: echo "::set-output name=dir::$(yarn cache dir)"
@@ -54,7 +54,7 @@ jobs:
           submodules: recursive
       - uses: actions/setup-node@v2
         with:
-          node-version: '14'
+          node-version: 18
       - name: Get yarn cache directory path
         id: yarn-cache-dir-path
         run: echo "::set-output name=dir::$(yarn cache dir)"
@@ -88,7 +88,7 @@ jobs:
           submodules: recursive
       - uses: actions/setup-node@v2
         with:
-          node-version: '14'
+          node-version: 18
       - name: Get yarn cache directory path
         id: yarn-cache-dir-path
         run: echo "::set-output name=dir::$(yarn cache dir)"
diff --git a/.github/workflows/tests_e2e_android.yml b/.github/workflows/tests_e2e_android.yml
index 90b42571..e9179980 100644
--- a/.github/workflows/tests_e2e_android.yml
+++ b/.github/workflows/tests_e2e_android.yml
@@ -31,7 +31,7 @@ jobs:
 
       - uses: actions/setup-node@v2
         with:
-          node-version: 14
+          node-version: 18
 
       # Set path variables needed for caches
       - name: Set workflow variables
@@ -83,17 +83,11 @@ jobs:
           max_attempts: 4
           command: yarn --no-audit --prefer-offline && npm i -g cavy-cli
 
-      - name: Configure JDK 1.11
-        uses: actions/setup-java@v2
+      - name: Configure JDK
+        uses: actions/setup-java@v4
         with:
-          distribution: 'adopt'
-          java-version: '11' # ubuntu-latest is about to default to 11, force it everywhere
-
-      - name: Verify JDK11
-        # Default JDK varies depending on different runner flavors, make sure we are on 11
-        # Run a check that exits with error unless it is 11 version to future-proof against unexpected upgrades
-        run: java -fullversion 2>&1 | grep '11.0'
-        shell: bash
+          distribution: 'temurin'
+          java-version: '17'
 
       - name: Build Android App
         uses: nick-invision/retry@v2
diff --git a/.github/workflows/tests_e2e_ios.yml b/.github/workflows/tests_e2e_ios.yml
index dbf44d4e..61de05e8 100644
--- a/.github/workflows/tests_e2e_ios.yml
+++ b/.github/workflows/tests_e2e_ios.yml
@@ -16,7 +16,7 @@ on:
 jobs:
   ios:
     name: iOS
-    runs-on: macos-11
+    runs-on: macos-latest
     # TODO matrix across APIs, at least 10 and 13 (lowest to highest)
     timeout-minutes: 60
     env:
@@ -30,16 +30,16 @@ jobs:
 
       - uses: actions/setup-node@v2
         with:
-          node-version: 14
+          node-version: 18
 
       - uses: maxim-lobanov/setup-xcode@v1
         with:
-          xcode-version: '13.0'
+          xcode-version: 'latest-stable'
 
       - name: Start Simulator
         # The first time you try to `yarn run:ios` after xcode-select, it fails, so get it out of the way...
         continue-on-error: true
-        run: xcrun simctl boot "iPhone 12"
+        run: xcrun simctl boot "iPhone 15"
 
       # Set path variables needed for caches
       - name: Set workflow variables
diff --git a/.github/workflows/tests_jest.yml b/.github/workflows/tests_jest.yml
index 47035f3e..283791df 100644
--- a/.github/workflows/tests_jest.yml
+++ b/.github/workflows/tests_jest.yml
@@ -28,7 +28,7 @@ jobs:
           submodules: recursive
       - uses: actions/setup-node@v2
         with:
-          node-version: 14
+          node-version: 18
       - name: Get yarn cache directory path
         id: yarn-cache-dir-path
         run: echo "::set-output name=dir::$(yarn cache dir)"
diff --git a/.github/workflows/tests_junit.yml b/.github/workflows/tests_junit.yml
index 93b66ce5..e22a190f 100644
--- a/.github/workflows/tests_junit.yml
+++ b/.github/workflows/tests_junit.yml
@@ -25,17 +25,11 @@ jobs:
         with:
           fetch-depth: 50
 
-      - name: Configure JDK 1.11
-        uses: actions/setup-java@v2
+      - name: Configure JDK
+        uses: actions/setup-java@v4
         with:
-          distribution: 'adopt'
-          java-version: '11' # ubuntu-latest is about to default to 11, force it everywhere
-
-      - name: Verify JDK11
-        # Default JDK varies depending on different runner flavors, make sure we are on 11
-        # Run a check that exits with error unless it is 11 version to future-proof against unexpected upgrades
-        run: java -fullversion 2>&1 | grep '11.0'
-        shell: bash
+          distribution: 'temurin'
+          java-version: '17'
 
       - name: Gradle Cache
         uses: actions/cache@v2