Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Facets that start with the same characters #85

Open
topless opened this issue Nov 6, 2019 · 1 comment
Open

Facets that start with the same characters #85

topless opened this issue Nov 6, 2019 · 1 comment
Labels
bug Something isn't working

Comments

@topless
Copy link
Member

topless commented Nov 6, 2019

When there are facets that start with the same name they cannot be both selected.

tags-bug

@ntarocco
Copy link
Contributor

ntarocco commented Mar 27, 2020

The solution might not be easy, I can give more context for who will work on it.

Here the test to add and reproduce the issue (Publication and Publicatio):

test('query with very similar query values.', () => {
    const state = [['file_type', 'pdf'], ['type', 'Publication']];
    const query = ['type', 'Publicatio'];

    const newState = updateQueryFilters(query, state);

    expect(newState).toEqual([
      ['file_type', 'pdf'],
      ['type', 'Publication'],
      ['type', 'Publicatio'],
    ]);

    const state2 = [['file_type', 'pdf'], ['type', 'Publicatio']];
    const query2 = ['type', 'Publication'];

    const newState2 = updateQueryFilters(query2, state2);

    expect(newState2).toEqual([
      ['file_type', 'pdf'],
      ['type', 'Publication'],
      ['type', 'Publicatio'],
    ]);
  });

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants