Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DiffTimestamps function #240

Closed
wants to merge 1 commit into from

Conversation

carlinmack
Copy link
Contributor

❤️ Thank you for your contribution!

Description

Please describe briefly your pull request.

At the moment we have toRelativeTime which produces a string like "in 2 minutes" or "2 minutes ago" from one timestamp.

In this PR I introduce diffTimestamps which produces a string like "2 minutes" from two time stamps.

Unfortunately I have had to write my own version of this as we are using an old version of Luxon. I'm not sure how much hassle it would be to upgrade Luxon.

image

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Frontend

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

@carlinmack
Copy link
Contributor Author

moving this code to invenio-jobs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant