ErrorMessage: remove content class wrapper #223
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpsherva
reviewed
Nov 10, 2023
| @@ -51,11 +51,11 @@ export class ErrorMessage extends Component { | |||
| return ( | |||
| <Message icon {...uiProps}> | |||
| {icon && <Icon name={icon} />} | |||
| <Message.Content role="alert"> | |||
| <div role="alert"> | |||
There was a problem hiding this comment.
just a small suggestion, wouldn't it be more pratical to fix it in the css instead? Otherwise we implement the message component from semantic ui in conflict with documentation, and each time there is Message.Content used we need to remember no to use it. Fixing the styling would solve it once for all and make it compliant with the documentation
|
CSS fixed in inveniosoftware/invenio-app-rdm#2532 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the white bg box in the error message component (caused by nested
.contentclasses).Before
After
