Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Technical upgrades #647

Open
ntarocco opened this issue Oct 22, 2024 · 0 comments
Open

Technical upgrades #647

ntarocco opened this issue Oct 22, 2024 · 0 comments

Comments

@ntarocco
Copy link
Contributor

ntarocco commented Oct 22, 2024

The app should go through various technical upgrades.

  1. we need to upgrade react-searchkit to the latest, and therefore, axios. This is not easy, because the NodeJS version might have to be upgraded, leading to a certain number of tests failures. For now, we had to pin cheerio to a specific version, and this should be removed at some point.
  2. we should upgrade NodeJS. However, this mean upgrading npm, and the biggest change is that, by default, newer versions of npm than the current v6 install peerDeps too. This cause issues. A workaround is to add the param --legacy-peer-deps to all npm command to simulate the previous behaviour.
  3. enzyme is completely abandoned. Anyway, in my opinion, snapshots testing did not turn out to be particularly useful. I propose to remove it entirely and tests too. For new test, we could use React Testing Library.
    If it is to be kept, or you the error that TextEncoder is not found, this commit should be added here too.
  4. we could explore removing craco, and come back to the default create react app. It was added because create react app does not support LESS by default, and it is suggested by the React SemanticUI doc. Today, there could be better ways. If this is done, then we need to remove the aliases defined for webpack.
  5. we should probably use the invenio linter rules.
  6. what about upgrading React?
  7. partial upgrades done in Upgrade npm #629
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant