Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub alternate zipball URL not set when tag and branch having same name #172

Open
ptamarit opened this issue Sep 6, 2024 · 0 comments · May be fixed by #173
Open

GitHub alternate zipball URL not set when tag and branch having same name #172

ptamarit opened this issue Sep 6, 2024 · 0 comments · May be fixed by #173
Assignees

Comments

@ptamarit
Copy link
Member

ptamarit commented Sep 6, 2024

Package version (if known): 1.5.2

Describe the bug

For repositories where a branch has the same name as the tag, fetching the alternate URL for the zipball does not work since the logic assigns the results of the alternate fetching to a local variable which is lost at the end of the method.

Steps to Reproduce

  1. Try to perform a release on a repository with a tag and a branch with the same name.
  2. The release will fail with a status 300.

Expected behavior

The alternate zipball URL should be fetched.

@ptamarit ptamarit changed the title GitHub alternate zipball URL not fetched when tag and branch having same name GitHub alternate zipball URL not set when tag and branch having same name Sep 6, 2024
@ptamarit ptamarit moved this to In review in Sprint Q4/2024 🎄 Sep 6, 2024
@ptamarit ptamarit self-assigned this Sep 16, 2024
@ptamarit ptamarit moved this from In review to In progress in Sprint Q4/2024 🎄 Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Ready
Development

Successfully merging a pull request may close this issue.

1 participant