Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

requests: fixing comments notifications for member requests #1261

Closed
slint opened this issue Dec 9, 2024 · 0 comments · Fixed by #1262 or inveniosoftware/invenio-app-rdm#2939
Closed

requests: fixing comments notifications for member requests #1261

slint opened this issue Dec 9, 2024 · 0 comments · Fixed by #1262 or inveniosoftware/invenio-app-rdm#2939

Comments

@slint
Copy link
Member

slint commented Dec 9, 2024 •
edited
Loading

Request comments on member invitations and membership requests are not working because the recipients can be communities, that the base comment notification builder cannot resolve to specific user email recipients.

The default set of community recipients should be managers and owners (since they're the that have permissions to accept/reject member-related requests).

(Note, see how a similar fix was applied at #1256)
@slint slint moved this to In progress in Sprint Q1/2025 Dec 9, 2024
This was referenced Dec 9, 2024
Merged
Merged
@carlinmack carlinmack moved this from In progress to In review 🔎 in Sprint Q1/2025 Dec 11, 2024
@carlinmack carlinmack removed their assignment Dec 11, 2024
@slint slint moved this from In review 🔍 to To release 🤖 in Sprint Q1/2025 Jan 14, 2025
@slint slint moved this from To release 🤖 to In progress in Sprint Q1/2025 Jan 16, 2025
@slint slint moved this from In progress to Ready in Sprint Q1/2025 Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Sprint Q1/2025
Status: Ready
Milestone
No milestone
2 participants
@slint @carlinmack