Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[typescript][enhancement]: Update typescript definitions to match the latest SDK v3.0.2 #100

Open
abisalehalliprasan opened this issue Oct 13, 2020 · 3 comments
Labels
enhancement New feature or request hacktoberfest

Comments

@abisalehalliprasan
Copy link
Collaborator

Hacktoberfest is underway right now and we would love for you to contribute 🚀 . More information on #hacktoberfest is here

Develop-with-Intuit for Hacktoberfest

Problem

Update typescript definitions file to match the latest SDK v3.0.2
Ref : index.d.ts file

Fix Needed

Add the missing API typings ( interfaces/classes ) into the definition file ( index.d.ts )

You can compare using the latest SDK version v3.0.2

Instructions to use the sample app

In order to test the typings locally from the sample project, you'll need to link the intuit-oauth package with yarn or npm.

# Link local intuit-oauth branch with typings support to sample typescript project
yarn link
cd sample/typescript
yarn link intuit-oauth

PR Guidelines

Kindly follow the below instructions to submit your PR :

  • Fork and clone the repository (typescript branch).
  • Run npm install for dependencies.
  • Test all your changes.
  • Run npm test to execute all specs.

Once ready, please submit a PR to the typescript branch here.
Note : PR's will be merged to the master branch once all the testing is completed.

@abisalehalliprasan abisalehalliprasan changed the title [typescript][enhancement]: Update typescript definitions to match the latest SDK v3.0.2**Cards** [typescript][enhancement]: Update typescript definitions to match the latest SDK v3.0.2 Oct 13, 2020
@shlok-kothari
Copy link

Hi @abisalehalliprasan I would like to take a shot at this

@abisalehalliprasan
Copy link
Collaborator Author

@shlok-kothari : Awesome. Go for it. 👍

@barakplasma
Copy link

since this was merged, I suggest closing this issue.
By the way, since release 4.0 happened, have the typescript definitions been updated since then? @abisalehalliprasan

@rajeshgupta723 rajeshgupta723 added the enhancement New feature or request label Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hacktoberfest
Projects
None yet
Development

No branches or pull requests

4 participants