Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Github abuse rate limit error #2458

Open
restfulhead opened this issue May 2, 2024 · 4 comments · May be fixed by #2459
Open

Github abuse rate limit error #2458

restfulhead opened this issue May 2, 2024 · 4 comments · May be fixed by #2459
Labels
bug Something isn't working

Comments

@restfulhead
Copy link
Contributor

restfulhead commented May 2, 2024 •
edited
Loading

For repos with a lot of commits/pull-requests, the release process fails with:

✖  error     Went over abuse rate limit GET /repos/{owner}/{repo}/releases/latest, retrying in 1m.
✖  error     Went over abuse rate limit GET /repos/{owner}/{repo}/issues/{issue_number}, retrying in 1m.
✖  error     Went over abuse rate limit GET /repos/{owner}/{repo}/issues/{issue_number}, retrying in 1m.
✖  error     Went over abuse rate limit GET /repos/{owner}/{repo}/issues/{issue_number}, retrying in 1m.

Expected behavior

Release process should not break.

Environment information:

v11.1.6

Additional context

This seems to be a secondary rate limit error. I don't see any prior log messages like Request quota exhausted....

octokit/plugin-throttling has a fallbackSecondaryRateRetryAfter configuration option. Perhaps that could be exposed also in the auto configuration so that I could increase it?

Alternatively we could upgrade @octokit/plugin-throttling to >=v5.2.3, because the rate limit was increased from 5 to 60.

Update: The upgrade seems to be the way to go, because not only was the rate limit increased, also the implementation was improved.
@restfulhead restfulhead added the bug Something isn't working label May 2, 2024
restfulhead added a commit to restfulhead/auto that referenced this issue May 2, 2024
@restfulhead
chore: upgrade octokit dependencies
903f5a9 
The main goal here is to upgrade `@octokit/plugin-throttling` to `5`, so that the secondary rate limit wait time is increased, wich hopefully fixes intuit#2458. This required other dependencies to be upgraded. The `resolutions` for `@octokit/plugin-rest-endpoint-methods` is necessary, because without it it pulls in `10.0.0` of `@octokit/types` which isn't compatible with the other libraries.
@restfulhead restfulhead linked a pull request May 2, 2024 that will close this issue
Open
4 tasks
restfulhead added a commit to restfulhead/auto that referenced this issue May 10, 2024
@restfulhead
fix: increase fallbackSecondaryRateRetryAfter to new default value of 60
911266c 
The secondary rate limit default value in `@octokit/plugin-throttling` was increased to 60 in version 5. However, because we are still using an older version, we manually set the option here. Hopefully fixes intuit#2458.
@hipstersmoothie
Copy link
Collaborator

I will def buy you a coffee if you land that PR!

@VictorPascualV
Copy link

Our team is also blocked by that issue, we'd love an update on its progress 🙏

We already helped by fixing some failing tests that should speed up the expedition of this change.

restfulhead added a commit to restfulhead/auto that referenced this issue Jul 3, 2024
@restfulhead
chore: upgrade octokit dependencies
319e52b 
The main goal here is to upgrade `@octokit/plugin-throttling` to `5`, so that the secondary rate limit wait time is increased, wich hopefully fixes intuit#2458. This required other dependencies to be upgraded. The `resolutions` for `@octokit/plugin-rest-endpoint-methods` is necessary, because without it it pulls in `10.0.0` of `@octokit/types` which isn't compatible with the other libraries.
@nick-infinitegiving
Copy link

Our team is impacted by this as well. Any updates on the issue? -Thx

@JesusTheHun
Copy link

I've noticed that when this error surfaces, it doesn't exit with status code 1, so the job is marked as successful !

See this job on one of my repo : https://github.com/JesusTheHun/storybook-addon-remix-react-router/actions/runs/12053798314/job/33610310120#step:7:53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: upgrade octokit dependencies restfulhead/auto
5 participants
@JesusTheHun @restfulhead @hipstersmoothie @VictorPascualV @nick-infinitegiving