Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A suggestion and a word of caution re: build performance #53

Open
davidfurlong opened this issue Jan 16, 2019 · 0 comments
Open

A suggestion and a word of caution re: build performance #53

davidfurlong opened this issue Jan 16, 2019 · 0 comments

Comments

@davidfurlong
Copy link

davidfurlong commented Jan 16, 2019

I commented here: #43 on what I thought was a bug with this library.

However it wasn't a bug with this library at all. I, as a naive developer confused by webpack took this plugin literally and applied the AntdScssThemePlugin.themify() changes to my rule which matched all my scss files. This caused this entire theme to rebuild on every scss file change (incremental build) adding ~10seconds and also slowed down the initial build by ~10s. This seems to be intended, as I think it makes possible the features here: https://github.com/intoli/antd-scss-theme-plugin#use-ant-designs-customized-color-and-theme-variables however we don't use it in this way, and we have alot of scss files.

If my understanding is correct, many users would benefit from avoiding wrapping all their scss loaders with this library. In this case I think an update to the README with the expected build speed savings would be prudent, which I would be happy to contribute to

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant