Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[store] Result list is silently limited to 10000 items #1120

Open
barroco opened this issue Sep 17, 2024 · 1 comment
Open

[store] Result list is silently limited to 10000 items #1120

barroco opened this issue Sep 17, 2024 · 1 comment
Labels
bug Software behaves incorrectly because of this issue dss Relating to one of the DSS implementations P2 Normal priority

Comments

@barroco
Copy link
Contributor

barroco commented Sep 17, 2024

Currently, the DSS returns a maximum of 10000 items to clients when listing resources for RID and SCD. This value is set by the MaxResultLimit constant.
It seems that it was introduced to address OOM issues few years ago.

This issue has been created to discuss possible alternative approaches and make sure responses of the DSS are exhaustives.

@barroco barroco changed the title [scd] Result list is silently limited to 10000 items [store] Result list is silently limited to 10000 items Sep 17, 2024
@barroco
Copy link
Contributor Author

barroco commented Sep 18, 2024

This issue was discussed during the contributors sync call on 17/09/2024 and it was agreed the fact that the DSS is trimming results silently is an issue. The preferred approach discussed was to fail the response with a 400 or more appropriate error code in case the number of items is too big.

Pagination was mentioned as well but it would require changing the API. Requesting clients to better scope their request to reduce the number of items was preferred.

@barroco barroco added P2 Normal priority bug Software behaves incorrectly because of this issue dss Relating to one of the DSS implementations labels Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Software behaves incorrectly because of this issue dss Relating to one of the DSS implementations P2 Normal priority
Projects
None yet
Development

No branches or pull requests

1 participant