Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[scd/isa] cleanup ISA repo implementation(s), notably IsaRepoV3 #1115

Open
Shastick opened this issue Sep 12, 2024 · 0 comments
Open

[scd/isa] cleanup ISA repo implementation(s), notably IsaRepoV3 #1115

Shastick opened this issue Sep 12, 2024 · 0 comments
Labels
dss Relating to one of the DSS implementations feature Issue would improve software P2 Normal priority

Comments

@Shastick
Copy link
Contributor

Shastick commented Sep 12, 2024

The isaRepoV3 struct has the following comment:

// The purpose od isaRepoV3 is solely to support backwards compatibility
// It will be deleted from the codebase when all existing production deployments have been upgraded to 3.1.0+.

This means that we might be able to clean up some code. (Ie, identification_service_area_v3.go and possibly subcriptions_v3.go)

This implementation of the repo is used if the database schema has a version that is smaller than 4.0.0

@BenjaminPelletier the comment above was added approximately 4 years ago: how likely is it that all real-world deployments that still pull in the latest updates of the DSS would still run on an old schema?

Knowing whether or not to get rid of this older implementation is relevant for some work happening for #814

@Shastick Shastick added P2 Normal priority dss Relating to one of the DSS implementations feature Issue would improve software labels Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dss Relating to one of the DSS implementations feature Issue would improve software P2 Normal priority
Projects
None yet
Development

No branches or pull requests

1 participant