Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include sub field in log output lines #1051

Open
jasonprado opened this issue Jul 4, 2024 · 1 comment
Open

Include sub field in log output lines #1051

jasonprado opened this issue Jul 4, 2024 · 1 comment
Labels
dss Relating to one of the DSS implementations feature Issue would improve software P2 Normal priority

Comments

@jasonprado
Copy link

jasonprado commented Jul 4, 2024

Is your feature request related to a problem? Please describe.
When examining DSS logs I would like to quickly filter requests from a specific authorized USS client.

Describe the solution you'd like
Include the sub field of the request's decoded JWT in a field in the JSON log entry for each request. req_sub would look parallel next to req_dump and similar fields.

Describe alternatives you've considered

  • Process logs and decode JWT headers then re-remit the log with the sub value extracted.
  • Extract the uss_base_url from certain operations and filter based on them. Not all requests have this, however.

Additional context
I'd like to contribute this if we can get consensus on adding it and the format.

@BenjaminPelletier BenjaminPelletier added P2 Normal priority feature Issue would improve software dss Relating to one of the DSS implementations labels Jul 17, 2024
@BenjaminPelletier
Copy link
Member

My input would be that this seems like a useful change that doesn't present any concerns I'm thinking of, as long as we aren't promising a particular log format long term (essentially making a soft API). Making it easier for a human to troubleshoot using logs seems very worthwhile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dss Relating to one of the DSS implementations feature Issue would improve software P2 Normal priority
Projects
None yet
Development

No branches or pull requests

2 participants