Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edition omnibar mis-aligned + clipped #10064

Open
cdrini opened this issue Nov 22, 2024 · 4 comments
Open

Edition omnibar mis-aligned + clipped #10064

cdrini opened this issue Nov 22, 2024 · 4 comments
Assignees
Labels
Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] Needs: Response Issues which require feedback from lead Priority: 3 Issues that we can consider at our leisure. [managed] Theme: CSS Issues related to CSS stylesheets. [managed] Theme: Design Issues related to UI design, branding, etc. [managed] Type: Bug Something isn't working. [managed]

Comments

@cdrini
Copy link
Collaborator

cdrini commented Nov 22, 2024

Problem

image

Also clipped awkwardly after having scrolled:
image

Reproducing the bug

  1. Go to any book page in mobile screen size, eg https://openlibrary.org/books/OL1088853M/Wizard%27s_First_Rule
  • Expected behavior: The arrow is vertically centred, and the text isn't so awkwardly clipped. This should likely be full width.
  • Actual behavior: Not centred; clipped.

Context

  • Browser (Chrome, Safari, Firefox, etc): FF
  • OS (Windows, Mac, etc): Win
  • Logged in (Y/N): Y
  • Environment (prod, dev, local): prod

Breakdown

Requirements Checklist

  • [ ]

Related files

Stakeholders


Instructions for Contributors

  • Please run these commands to ensure your repository is up to date before creating a new branch to work on this issue and each time after pushing code to Github, because the pre-commit bot may add commits to your PRs upstream.
@cdrini cdrini added Type: Bug Something isn't working. [managed] Priority: 3 Issues that we can consider at our leisure. [managed] Theme: Design Issues related to UI design, branding, etc. [managed] Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] Theme: CSS Issues related to CSS stylesheets. [managed] labels Nov 22, 2024
@Craig-Rosario
Copy link

Hi, I’m a first-time contributor and would love to work on this issue. Could you please assign it to me?

@github-actions github-actions bot added the Needs: Response Issues which require feedback from lead label Nov 23, 2024
@DachiCharkviani
Copy link

Hello, I am a first time contributor too, needing to contribute to an open source code for my college assignment. Would appreciate the assignment.

@cdrini
Copy link
Collaborator Author

cdrini commented Nov 27, 2024

Howdy @Craig-Rosario , go for it; assigning it to you. Please let us know if you have any questions.

I'll keep you in mind for another one @DachiCharkviani 👍

@cdrini cdrini removed the Needs: Response Issues which require feedback from lead label Nov 27, 2024
@DachiCharkviani
Copy link

@cdrini Thanks! I also commented on #10095. I would gladly work on that one. I added more information there in the comment of that issue.

@github-actions github-actions bot added the Needs: Response Issues which require feedback from lead label Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] Needs: Response Issues which require feedback from lead Priority: 3 Issues that we can consider at our leisure. [managed] Theme: CSS Issues related to CSS stylesheets. [managed] Theme: Design Issues related to UI design, branding, etc. [managed] Type: Bug Something isn't working. [managed]
Projects
None yet
Development

No branches or pull requests

3 participants