update tests and identifiers #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfalling
reviewed
Nov 23, 2024
bfalling
reviewed
Nov 23, 2024
bfalling
reviewed
Nov 23, 2024
bfalling
reviewed
Nov 23, 2024
bfalling
reviewed
Nov 23, 2024
bfalling
reviewed
Nov 23, 2024
bfalling
reviewed
Nov 23, 2024
bfalling
reviewed
Nov 23, 2024
There was a problem hiding this comment.
Great work on this. Some comments/questions/suggestions left.
Note that this PR is doing many things at once: switching to fixtures, adding cookies, adding new page tests, etc. It's probably too many things for one PR. You don't have to change this PR, but next time, please let each PR accomplish one thing, and split changes out into multiple PR's as appropriate. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.