Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enrichment vignette: change from pie-charting p-val to pie chart of -log(pval) #62

Open
yochannah opened this issue Jun 17, 2019 · 4 comments

Comments

@yochannah
Copy link
Member

https://bioconductor.org/packages/release/bioc/vignettes/InterMineR/inst/doc/Enrichment_Analysis_and_Visualization.html#piechart-and-barplot-graphs

Pies and bar charts are pretty, but given the fact that a smaller P value is better, it takes some figuring out to understand what's going on - the smaller the pie segment / the smaller the bar, the more significant it is.

One option could be to subtract all the values from 1 so smaller values get bigger slices, but that would also require some explaining. I think it might make more sense just to remove these two visualisations.

@rachellyne
Copy link
Member

Yep, you don't have to use the p-value. I think you can set the orderby to other things like geneNum. I think that's what we do in the Python tutorial for similar graphs and what we did last time.

@splaisan
Copy link

or use -log(pval) like in many other plots out there! :-)

@yochannah
Copy link
Member Author

@splaisan that would make a lot more sense, too!

@yochannah yochannah changed the title Enrichment vignette: suggest we remove the p-value bar chart and pie chart Enrichment vignette: change from pie-charting p-val to pie chart of -log(pval) Aug 20, 2019
@yochannah
Copy link
Member Author

I've added the hacktoberfest label to this - interested contributors, if you're interested in helping out, the chart in question is here: https://github.com/intermine/InterMineR/blob/master/vignettes/Enrichment_Analysis_and_Visualization.Rmd#L300

if you want to pick up this task

  1. Comment on this issue stating that you intend to work on the task
  2. When you're ready, add your work to the repo and create a pull request.

What to do if you need help

Mention @yochannah, tweet @yoyehudi, pop by to say hi on chat or if needed email [email protected] <3 note that we're only usually in the office during UK office hours and may not answer outside these times.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants