Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement: Consider adding a less verbose method for a single constraint #60

Open
yochannah opened this issue Jun 14, 2019 · 0 comments

Comments

@yochannah
Copy link
Member

Consider this code - when there is only one constraint, wrapping each element in datastructures seems unnecessarily verbose.

 setConstraints(
    paths = c("Gene"),
    operators = c("IN"),
    values = list("PL_Pax6_Targets")
  )

Suggestion
It would be nice to either overridethe method signature for setConstraints to allow something like this

 setConstraints(
    paths = "Gene",
    operators = "IN",
    values = "PL_Pax6_Targets"
  )

or alternatively, if this isn't something that can be done in R, maybe just adding the method setConstraint (note no s at the end) would achieve the same thing.

This is low priority but would probably be easy to implement while fixing more important constraint issues such as #58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant