From 12655356f47ebdfb39ec1fdba4e25a0b9c430dba Mon Sep 17 00:00:00 2001 From: Daniel Carter Date: Thu, 8 Oct 2020 08:28:32 +0100 Subject: [PATCH 1/2] fixes type on config erb --- lib/rails/generators/intercom/config/intercom.rb.erb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/rails/generators/intercom/config/intercom.rb.erb b/lib/rails/generators/intercom/config/intercom.rb.erb index b476920..331f788 100644 --- a/lib/rails/generators/intercom/config/intercom.rb.erb +++ b/lib/rails/generators/intercom/config/intercom.rb.erb @@ -129,6 +129,6 @@ IntercomRails.config do |config| # config.hide_default_launcher = true # # If you need to route your Messenger requests through a different endpoint than the default, replace the below with your app id, and uncomment below line. Generally speaking, this is not needed. - # config.api_base = https://{app_id}.intercom-messenger.com + # config.api_base = "https://#{config.app_id}.intercom-messenger.com" # end From 5276cd9a3db9a39c2008a549f067aff6cbc93ec5 Mon Sep 17 00:00:00 2001 From: Daniel Carter Date: Thu, 8 Oct 2020 08:30:35 +0100 Subject: [PATCH 2/2] clarifies the usage of this config option --- lib/rails/generators/intercom/config/intercom.rb.erb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/rails/generators/intercom/config/intercom.rb.erb b/lib/rails/generators/intercom/config/intercom.rb.erb index 331f788..cb9a3ff 100644 --- a/lib/rails/generators/intercom/config/intercom.rb.erb +++ b/lib/rails/generators/intercom/config/intercom.rb.erb @@ -128,7 +128,7 @@ IntercomRails.config do |config| # If you'd like to hide default launcher button uncomment this line # config.hide_default_launcher = true # - # If you need to route your Messenger requests through a different endpoint than the default, replace the below with your app id, and uncomment below line. Generally speaking, this is not needed. + # If you need to route your Messenger requests through a different endpoint than the default, uncomment the below line. Generally speaking, this is not needed. # config.api_base = "https://#{config.app_id}.intercom-messenger.com" # end