New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API Should not return 404 on input error #320

Open

tarjei opened this issue Sep 29, 2020 · 0 comments

Contributor

tarjei commented Sep 29, 2020

Version info

intercom-php version: 4.4
Intercom API version: 2.2
PHP version:7.4

Expected behavior

400 bad request

Actual behavior

404 not found

Steps to reproduce (as granular as possible, including screenshots where appropriate)

$this->intercomClient is the intercom/intercom-php client.
Given:

$this->intercomClient->post('contacts/merge', [
            'from' => $fromId,
            'to' => $toId,
        ]);

I get:
EXCEPTION: Not Found 404
Http\Client\Common\Exception\ClientErrorExceptionHeaders: {"Host":["api.intercom.io"],"Accept":["application/json"],"Content-Type":["application/json"],"User-Agent":["Intercom-PHP/4.4.0"],"Intercom-Version":["2.2"],"Authorization":["Bearer xxx"]}
https://api.intercom.io/contacts/merge

Logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment