From f4c1618b353af79da9d3ba03a21165999564c253 Mon Sep 17 00:00:00 2001 From: Wang Hangjie Date: Thu, 24 Oct 2024 09:54:34 -0700 Subject: [PATCH] Enhance PSNR Check for Luma (Y) Channel in VPP Sharpen Filter The current implementation of the PSNR check for the Luma (Y) channel raises exceptions for actual values exceeding reference values. This behavior is not reflective of typical processing scenarios where higher actual values are expected. Updated the `compare` function to only raise exceptions if the actual Luma (Y) value is lower than the reference value. Signed-off-by: Wang Hangjie --- lib/mixin/vpp.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/lib/mixin/vpp.py b/lib/mixin/vpp.py index bc3cce8b..f34e78a6 100644 --- a/lib/mixin/vpp.py +++ b/lib/mixin/vpp.py @@ -132,7 +132,10 @@ def compare(k, ref, actual): assert actual[-2] == 100, "Cb(U) should not be affected by SHARPEN filter" assert actual[-1] == 100, "Cr(V) should not be affected by SHARPEN filter" assert ref is not None, "Invalid reference value" - assert abs(ref[-3] - actual[-3]) < 0.25, "Luma (Y) out of baseline range" + # Only check if the actual Luma (Y) value is lower than the reference. + # If the actual value is lower than the reference by more than 0.25, raise an exception. + if actual[-3] < ref[-3]: + assert ref[-3] - actual[-3] < 0.25, f"Luma (Y) is lower than reference value: {actual[-3]} < {ref[-3]}" metrics2.check( metric = dict(type = "psnr"), compare = compare,