Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompressionTreeMultiplier should support mixed signed/unsigned operands #143

Closed
desmonddak opened this issue Nov 21, 2024 · 0 comments · Fixed by #144
Closed

CompressionTreeMultiplier should support mixed signed/unsigned operands #143

desmonddak opened this issue Nov 21, 2024 · 0 comments · Fixed by #144
Labels
enhancement New feature or request

Comments

@desmonddak
Copy link
Contributor

Motivation

It would be useful to have the multiplier components support a mix of signed and unsigned multiplier and multiplicand.
Today, it supports operands that are either both signed or both unsigned.
A workaround exists to support mixed by widening the unsigned operand by 1 bit. But in some cases this is not possible to do, or expensive for shorter operands.

Desired solution

Change the signed parameter to both operands (multiplier and multiplicand).
Change the signedOperands input to both operand types (say signedMultiplierOp and signedMultiplicandOp).
Modify the logic to separate the support of sign extension versus booth encoding of sign.

Alternatives considered

No response

Additional details

Consider the potential for using fixed sign versus runtime sign configuration for the parameter versus runtime-based configuration (do we need to support both or can we presume fully fixed and fully runtime configurable). Should we have, say, signedMultiplier (hardcoded) and signedMultiplicandOperand runtime configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant