[NEXMANAGE-899] Fix dispatcher not recording state file and causing snapshot failure #583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…napshot failure The dispatcher agent raises an exception when it fails to retrieve the state value from the state file. This results in the dispatcher not recording the restart_reason and snapshot_num, which are important for the rollback scenario. This PR removes the exception that occurs when the dispatcher agent is unable to retrieve the state value from the state file. In cases where the state is None, the dispatcher will still record the restart_reason and snapshot_num. Signed-off-by: yengliong <[email protected]>
|
Would like to see integration test passing -- will try triggering it later (Jenkins is down now). |
|
@yengliong93 this looks good but I would like to run it through integration test first. |
|
Both build and integration tests are blocked by Penang power outage. |
gblewis1
approved these changes
Oct 23, 2024
|
IT is failing. Checking it... |
|
Unit tests fix and IT pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PULL DESCRIPTION
The dispatcher agent raises an exception when it fails to retrieve the state value from the state file. This results in the dispatcher not recording the restart_reason and snapshot_num, which are important for the rollback scenario.
This PR removes the exception that occurs when the dispatcher agent is unable to retrieve the state value from the state file. In cases where the state is None, the dispatcher will still record the restart_reason and snapshot_num.
Impact Analysis
CODE MAINTAINABILITY
go fmtorformat-python.shas applicableCode must act as a teacher for future developers