Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEXMANAGE-906] Truncate granular log instead of removing it #582

Merged
merged 3 commits into from
Oct 24, 2024

Conversation

yengliong93
Copy link
Contributor

PULL DESCRIPTION

The dispatcher agent is unable to remove the granular log file in a read-only system. This PR modifies the dispatcher agent so that it truncates the file instead of removing it.

Impact Analysis

Info Please fill out this column
Root Cause Specifically for bugs, empty in case of no variants
Jira ticket Add the name to the Jira ticket eg: "NEXMANAGE-622". Automation will do the linking to Jira

CODE MAINTAINABILITY

  • Added required new tests relevant to the changes
  • Updated Documentation as relevant to the changes
  • PR change contains code related to security
  • PR introduces changes that break compatibility with other modules/services (If YES, please provide description)
  • Run go fmt or format-python.sh as applicable
  • Update Changelog
  • Integration tests are passing
  • If Cloudadapter changes, check Azure connectivity manually

Code must act as a teacher for future developers

@yengliong93 yengliong93 changed the title [NEXMANAGE-9096] Truncate granular log instead of removing it [NEXMANAGE-906] Truncate granular log instead of removing it Oct 22, 2024
The dispatcher agent is unable to remove the granular log file in a read-only system. This PR modifies the dispatcher agent so that it truncates the file instead of removing it.

Signed-off-by: yengliong <[email protected]>
@yengliong93 yengliong93 force-pushed the truncate-granular-log branch from 1274f29 to 014b984 Compare October 22, 2024 05:44
@yengliong93
Copy link
Contributor Author

@gblewis1 please have a review, thanks.

@gblewis1
Copy link
Contributor

gblewis1 commented Oct 22, 2024

Would like to run this through integration test, but Jenkins seems to be down. Will check later.

@gblewis1
Copy link
Contributor

Jenkins still down due to Penang power outage. Approved, but need integration test first.

@yengliong93
Copy link
Contributor Author

Integration tests pass.

@yengliong93 yengliong93 merged commit 63cba80 into develop Oct 24, 2024
7 checks passed
@yengliong93 yengliong93 deleted the truncate-granular-log branch October 24, 2024 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants