-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NEXMANAGE-737] Sota cancel mode with threading event method #567
Conversation
Hi @gblewis1, this PR contains the cancel mode with threading.event method. Unfortunately, it's not functioning as expected. More details are in #559 (comment). It seems like the |
622ac8f
to
4010119
Compare
The threading event method is actually working. Previously, there was only one place to check the event.is_set. The SOTA process was running too quickly, bypassing that check. I have now added another check after |
147ba2e
to
bf8a9e1
Compare
bf8a9e1
to
baee1d8
Compare
@gblewis1 please have a review, thanks. |
This PR implements the sota cancel mode using a threading event flag. When the thread is created, it will be added to a thread list. When the dispatcher receives the sota cancel request, it checks the current running thread and retrieves its sota type. If it is a download-only sota, the dispatcher sets the event flag to issue a cancel request. Please note that the first inbc command should be terminated before sending inbc cancel command as they will be sharing the same mqtt connection. Signed-off-by: yengliong <[email protected]>
0476299
to
f71e149
Compare
PULL DESCRIPTION
This PR implements the sota cancel mode using a threading event flag. When the thread is created, it will be added to a thread list.
When the dispatcher receives the sota cancel request, it checks the current running thread and retrieves its sota type. If it is a download-only sota, the dispatcher sets the event flag to issue a cancel request.
Please note that the first inbc command should be terminated before sending inbc cancel command as they will be sharing the same mqtt connection.
Impact Analysis
CODE MAINTAINABILITY
go fmt
orformat-python.sh
as applicableCode must act as a teacher for future developers