Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract granular log handler from SOTA and fix mocking in unit tests #565

Merged
merged 4 commits into from
Oct 7, 2024

Conversation

gblewis1
Copy link
Contributor

@gblewis1 gblewis1 commented Oct 5, 2024

PULL DESCRIPTION

This PR extracts a 'granular log handler' from sota.py and fixes mocking of its unit tests so
they will run as non-root. Previously, they were trying to modify files under /var/....

Impact Analysis

Info Please fill out this column
Root Cause docker test container runs tests as root
Jira ticket

CODE MAINTAINABILITY

  • Added required new tests relevant to the changes
  • Updated Documentation as relevant to the changes
  • PR change contains code related to security
  • PR introduces changes that break compatibility with other modules/services (If YES, please provide description)
  • Run go fmt or format-python.sh as applicable
  • Update Changelog
  • Integration tests are passing
  • If Cloudadapter changes, check Azure connectivity manually

Code must act as a teacher for future developers

@gblewis1 gblewis1 marked this pull request as ready for review October 5, 2024 04:00
@gblewis1 gblewis1 requested a review from nmgaston as a code owner October 5, 2024 04:00
@gblewis1
Copy link
Contributor Author

gblewis1 commented Oct 5, 2024

@yengliong93 please review

@gblewis1
Copy link
Contributor Author

gblewis1 commented Oct 5, 2024

Integration tests running

@yengliong93
Copy link
Contributor

@gblewis1 LGTM. The integration test is failing due to the coverage hasn't met the target.

@gblewis1 gblewis1 merged commit 436c41f into develop Oct 7, 2024
15 checks passed
@gblewis1 gblewis1 deleted the gblewis1/fix-sota-unit-tests-cli branch October 7, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants