Extract granular log handler from SOTA and fix mocking in unit tests #565
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PULL DESCRIPTION
This PR extracts a 'granular log handler' from
sota.py
and fixes mocking of its unit tests sothey will run as non-root. Previously, they were trying to modify files under
/var/...
.Impact Analysis
CODE MAINTAINABILITY
go fmt
orformat-python.sh
as applicableCode must act as a teacher for future developers