Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JSON schema validation for Node Update message #558

Merged
merged 17 commits into from
Oct 3, 2024

Conversation

nmgaston
Copy link
Contributor

@nmgaston nmgaston commented Oct 1, 2024

PULL DESCRIPTION

  • Performs a JSON schema validation on the Dispatcher side of the node update message prior to sending the message to cloudadapter.
  • Removes the extra job ID in send Results in the Dispatcher class
  • Fixes the SQL statement used to get the started job which was requiring the above workaround to exist.
  • Fixes a bug where the string coming from SOTA was missing a "

Impact Analysis

Info Please fill out this column
Root Cause Incorrect SQL Statement to get started job
Jira ticket NEXMANAGE-747

CODE MAINTAINABILITY

  • Added required new tests relevant to the changes
  • Updated Documentation as relevant to the changes
  • PR change contains code related to security
  • PR introduces changes that break compatibility with other modules/services (If YES, please provide description)
  • Run go fmt or format-python.sh as applicable
  • Update Changelog
  • Integration tests are passing
  • If Cloudadapter changes, check Azure connectivity manually

Code must act as a teacher for future developers

@nmgaston nmgaston marked this pull request as ready for review October 2, 2024 03:55
@nmgaston nmgaston requested a review from gblewis1 as a code owner October 2, 2024 03:55
@nmgaston nmgaston marked this pull request as draft October 2, 2024 04:00
@nmgaston nmgaston marked this pull request as ready for review October 2, 2024 05:33
@gblewis1
Copy link
Contributor

gblewis1 commented Oct 2, 2024

Please address checklist items:

  • Update Changelog
  • Integration test
  • Run format-python.sh

@nmgaston nmgaston requested a review from gblewis1 October 3, 2024 22:27
Accidentally removed line
@nmgaston nmgaston merged commit b6943c3 into develop Oct 3, 2024
7 checks passed
@nmgaston nmgaston deleted the changeUpdateNodeFormatToXML branch October 3, 2024 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants