-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GMMLib includes files are all over the place. #5
Comments
Will fix hardcoded path, but combining all include headers in single folder cannot be done right now as it requires coordination between dependent GmmLib clients. It will be revisited in future but cannot commit on it at this moment. Were you specific issue due to current organization of header files, one from root inc and other form GmmLib/inc? |
Really should commit to fixing the header organization sooner than later... otherwise it just creates headaches for everyone trying to use the library and decreases the likelihood of wider adoption and project success. |
is there an update on this? |
bruh |
Please consider having all includes headers required to compile Media Driver in a single include folder.
There's one in root folder inc and one more in Gmmlib/inc.
Consider also removing hardcoded path like this one in Gmmlib.h that breaks if user uses -DINC_PATH
#include "../../inc/umKmInc/sharedata.h"
The text was updated successfully, but these errors were encountered: