Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GMMLib includes files are all over the place. #5

Open
rlim77 opened this issue Jan 4, 2018 · 4 comments
Open

GMMLib includes files are all over the place. #5

rlim77 opened this issue Jan 4, 2018 · 4 comments

Comments

@rlim77
Copy link

rlim77 commented Jan 4, 2018

Please consider having all includes headers required to compile Media Driver in a single include folder.

There's one in root folder inc and one more in Gmmlib/inc.

Consider also removing hardcoded path like this one in Gmmlib.h that breaks if user uses -DINC_PATH

#include "../../inc/umKmInc/sharedata.h"

@drprajap
Copy link
Contributor

Will fix hardcoded path, but combining all include headers in single folder cannot be done right now as it requires coordination between dependent GmmLib clients. It will be revisited in future but cannot commit on it at this moment.

Were you specific issue due to current organization of header files, one from root inc and other form GmmLib/inc?

@uartie
Copy link
Contributor

uartie commented Jun 28, 2018

Really should commit to fixing the header organization sooner than later... otherwise it just creates headaches for everyone trying to use the library and decreases the likelihood of wider adoption and project success.

@chivakker
Copy link

is there an update on this?

@FirewallDaProtogen
Copy link

bruh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants