Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bitset range set #45

Merged
merged 3 commits into from
Jan 5, 2024
Merged

Add bitset range set #45

merged 3 commits into from
Jan 5, 2024

Conversation

elbeno
Copy link
Contributor

@elbeno elbeno commented Jan 2, 2024

No description provided.

@lukevalenty
Copy link
Contributor

Ohh, looks interesting! What is it? 😆

@elbeno
Copy link
Contributor Author

elbeno commented Jan 2, 2024

A couple of improvements to bitset that will be useful for intel/compile-time-init-build#434

@elbeno elbeno force-pushed the add-bitset-range-set branch from 5ee30cd to b444dcf Compare January 2, 2024 22:25
AshleyRoll added a commit to AshleyRoll/compile-time-init-build that referenced this pull request Jan 3, 2024
Copy link
Contributor

@lukevalenty lukevalenty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it!

I've encountered problems generating bit masks equal to the size of the integral type used. It would be nice to see a unit test that covers this case. For example, set and reset all bits in a uint64_t.

@elbeno elbeno merged commit 805853a into intel:main Jan 5, 2024
24 checks passed
@elbeno elbeno deleted the add-bitset-range-set branch January 5, 2024 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants