Skip to content
This repository has been archived by the owner on Sep 20, 2021. It is now read-only.

HepData parent records should not show in External tab #403

Open
kaplun opened this issue Jun 8, 2017 · 3 comments
Open

HepData parent records should not show in External tab #403

kaplun opened this issue Jun 8, 2017 · 3 comments
Assignees
Labels

Comments

@kaplun
Copy link

kaplun commented Jun 8, 2017

Now that Datasets are having a DOIs (following migration to hepdata.net) Datasets appear on the external Tab.
E.g. see: https://inspirehep.net/author/profile/B.Storaci.1

@kaplun kaplun added the bug label Jun 8, 2017
@kaplun
Copy link
Author

kaplun commented Nov 21, 2017

Uh! This is still buggy. Maybe something that @tsgit might fix? Anyway not at all criticial, so can be closed as anyway on Labs will be reimplemented from scratch.

@kaplun kaplun closed this as completed Nov 21, 2017
@tsgit
Copy link

tsgit commented Nov 23, 2017

well not really.

the description is wrong. datasets don't actually appear, because

https://github.com/inspirehep/invenio/blob/prod/modules/webauthorprofile/lib/webauthorprofile_corefunctions.py#L443

what does appear is the parent record, because Inspire doesn't have the DOI for the hepdata copy of the associated record

e.g
https://inspirehep.net/author/profile/B.Storaci.1
points to
https://www.hepdata.net/record/ins1208105

which has tables that do not show in the external tab. it's just the parent record that shows

T.

@tsgit
Copy link

tsgit commented Nov 23, 2017

so the problem here is that hepdata mints its own DOI for the parent record
https://www.hepdata.net/record/ins1208105

and its not what Inspire has. the corresponding record on Inspire is

https://inspirehep.net/record/1208105

they have different DOIs.

What we have to look for (after recent changes to metadata) is

001208105 035__ $$9HEPDATA$$ains1208105

@michamos

T.

@tsgit tsgit reopened this Nov 23, 2017
@tsgit tsgit changed the title Datasets are now appearing also in External tab HepData parent records should not show in External tab Dec 4, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants