Questions for tests of pool function

[pengguanya]

@gowerc @nociale

rbmi/tests/testthat/test-pool.R

Line 15 in a45df71

expect_equal(actual_res, mice_res1)

What is the object mice_res1 and where was it defined? What is the purpose of this test in general terms?

rbmi/tests/testthat/test-pool.R

Lines 850 to 853 in a45df71

	x$results[[1]]$p1$est <- 9999
	pooled_2 <- pool(x)
	expect_equal(pooled_2$pars$p1$est, x$results[[1]]$p1$est)

It seems weird to me that values in results are reassigned and then re-checked against a new pool result. Can you explain the purpose of this test?

[gowerc]

Hey @pengguanya ,

For your first question, I think there was an issue with the installation of older versions of the mice package so instead of including it into our suggests I just pre-computed the value and then stored the raw value in the project (rather than the code to create it). The raw values are populated in tests/testthat/helper-mice.R (note that all files in this folder with the name helper-*.R are loaded in advance of running any of the test files and as such can be used to define objects/data that are available for all subsequent test scripts).

Ideally I should have saved the code used to produce the object....

[gowerc]

To your second question, this test is attempting to show two separate things,

1. the first result value is used as the point estimate, i.e. the point estimate is equal exactly to the first result
2. the following tests show that the first result is ONLY used for the point estimate, i.e. having changed the first result the remaining SE/df terms are not affected.

Let me now if you need any more clarity on this.