Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

342 sorting #368

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

342 sorting #368

wants to merge 4 commits into from

Conversation

bzkrouse
Copy link
Collaborator

@bzkrouse bzkrouse commented Jan 3, 2025 •
edited
Loading

What changes are proposed in this pull request?

  • Style this entry in a way that can be copied directly into NEWS.md. (#, @)

Provide more detail here as needed.

Reference GitHub issue associated with pull request. e.g., 'closes #'
closes #342
Also resolves #326

Pre-review Checklist (if item does not apply, mark is as complete)

  • All GitHub Action workflows pass with a ✅
  • PR branch has pulled the most recent updates from master branch: usethis::pr_merge_main()
  • If a bug was fixed, a unit test was added.
  • Code coverage is suitable for any new functions/features (generally, 100% coverage for new code): devtools::test_coverage()
  • Request a reviewer

Reviewer Checklist (if item does not apply, mark is as complete)

  • If a bug was fixed, a unit test was added.
  • Run pkgdown::build_site(). Check the R console for errors, and review the rendered website.
  • Code coverage is suitable for any new functions/features: devtools::test_coverage()

When the branch is ready to be merged:

  • Update NEWS.md with the changes from this pull request under the heading "# cards (development version)". If there is an issue associated with the pull request, reference it in parentheses at the end update (see NEWS.md for examples).
  • All GitHub Action workflows pass with a ✅
  • Approve Pull Request
  • Merge the PR. Please use "Squash and merge" or "Rebase and merge".

@bzkrouse bzkrouse requested a review from ddsjoberg January 3, 2025 18:40
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 3, 2025 •
edited
Loading

Unit Tests Summary

  1 files  180 suites   45s ⏱️
177 tests  94 ✅  83 💤 0 ❌
329 runs  227 ✅ 102 💤 0 ❌

Results for commit 2c11ead.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 3, 2025 •
edited
Loading

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
shift_ard_columns 💚 $1.63$ $-1.15$ $-5$ $+1$ $0$ $0$
tidy_ard_row_order 👶 $+0.23$ $+1$ $+1$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
add_calculated_row 💚 $1.35$ $-1.17$ add_calculated_row_x_
ard_categorical 👶 $+0.01$ ard_categorical_ordering_for_multiple_strata
ard_continuous 💔 $0.41$ $+3.32$ ard_continuous_works
ard_hierarchical 💚 $9.67$ $-2.08$ ard_hierarchical_works_without_by_variables
ard_strata 💚 $2.82$ $-2.10$ ard_strata_works
shift_ard_columns 💚 $1.63$ $-1.15$ rename_ard_columns_works
tidy_ard_row_order 👶 $+0.23$ tidy_ard_row_order_works

Results for commit fb7a9e7

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 3, 2025 •
edited
Loading

badge

Code Coverage Summary

Filename                       Stmts    Miss  Cover    Missing
---------------------------  -------  ------  -------  -------------------------------
R/add_calculated_row.R            46       0  100.00%
R/apply_fmt_fn.R                 106       0  100.00%
R/ard_attributes.R                46       1  97.83%   57
R/ard_categorical.R              352      10  97.16%   239, 396-400, 407-408, 585, 619
R/ard_complex.R                   36       1  97.22%   83
R/ard_continuous.R               187       3  98.40%   208-209, 308
R/ard_dichotomous.R               80       1  98.75%   62
R/ard_hierarchical.R              72       0  100.00%
R/ard_missing.R                   58       1  98.28%   50
R/ard_pairwise.R                  46       0  100.00%
R/ard_stack_hierarchical.R       232       1  99.57%   455
R/ard_stack.R                     90       1  98.89%   117
R/ard_strata.R                    33       0  100.00%
R/ard_total_n.R                   10       0  100.00%
R/as_card_fn.R                     8       0  100.00%
R/as_card.R                        5       0  100.00%
R/as_nested_list.R                41       0  100.00%
R/bind_ard.R                      47      11  76.60%   74-85
R/check_ard_structure.R           39       6  84.62%   31, 55-59
R/default_stat_labels.R           18       0  100.00%
R/eval_capture_conditions.R       30       0  100.00%
R/get_ard_statistics.R            16       0  100.00%
R/mock.R                         137       2  98.54%   116, 244
R/nest_for_ard.R                  71       1  98.59%   60
R/print_ard_conditions.R          78       0  100.00%
R/print.R                         80       0  100.00%
R/process_selectors.R            126       1  99.21%   337
R/replace_null_statistic.R        11       0  100.00%
R/round5.R                         1       0  100.00%
R/selectors.R                     19       0  100.00%
R/shift_ard_columns.R            102       1  99.02%   185
R/shuffle_ard.R                  129       0  100.00%
R/summary_functions.R             25       1  96.00%   59
R/tidy_ard_order.R                23       0  100.00%
R/tidy_as_ard.R                   40       0  100.00%
R/update_ard.R                    53       0  100.00%
R/utils.R                         24       0  100.00%
TOTAL                           2517      42  98.33%

Diff against main

Filename               Stmts    Miss  Cover
-------------------  -------  ------  --------
R/ard_attributes.R        +1       0  +0.05%
R/ard_categorical.R       +2       0  +0.02%
R/ard_continuous.R        +1       0  +0.01%
R/tidy_ard_order.R        -3       0  +100.00%
R/tidy_as_ard.R           +1       0  +100.00%
TOTAL                     +2       0  +0.00%

Results for commit: 2c11ead

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddsjoberg ddsjoberg Awaiting requested review from ddsjoberg

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should we have opinionated sorting of results? ard_categorical() with multiple strata sorting
1 participant
@bzkrouse