-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
See #1719: Added Co-Author JSON-LD support. #1720
Merged
ziodave
merged 2 commits into
insideout10:develop
from
mauanga:feature/1719-co-author-support
Jan 3, 2024
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,53 @@ | ||
<?php | ||
|
||
/** | ||
* Filter the author object to add the co-authors. | ||
* | ||
* This filter checks if there are co-authors or a single author and | ||
* returns a JSON-LD fragment for the author(s). | ||
* | ||
* @param array $value { | ||
* @type array $author The author JSON-LD structure. | ||
* @type int[] $references An array of post IDs. | ||
* } | ||
* @param int $post_id The post ID. | ||
* | ||
* @return array An array with the updated JSON-LD and references. | ||
* | ||
* @since 3.51.4 | ||
* | ||
* @see https://www.geeklab.info/2010/04/wordpress-pass-variables-by-reference-with-apply_filter/ | ||
*/ | ||
function _wl_jsonld_author__author_filter( $args_arr, $post_id ) { | ||
|
||
$author = $args_arr['author']; | ||
$references = $args_arr['references']; | ||
|
||
$coauthor_plugin_path = 'co-authors-plus/co-authors-plus.php'; | ||
|
||
// If the co-authors plugin is active. | ||
if ( is_plugin_active( $coauthor_plugin_path ) && function_exists( 'get_coauthors' ) ) { | ||
|
||
$coauthors = get_coauthors( $post_id ); | ||
|
||
// And we have multiple authors on a post. | ||
if ( count( $coauthors ) > 1 ) { | ||
|
||
// Clear the existing author. | ||
$author = array(); | ||
|
||
// Build array of authors. | ||
foreach ( $coauthors as $coauthor ) { | ||
$author[] = Wordlift_Post_To_Jsonld_Converter::get_instance()->get_author( $coauthor->ID, $references ); | ||
} | ||
} | ||
} | ||
|
||
return array( | ||
'author' => $author, | ||
'references' => $references, | ||
); | ||
} | ||
|
||
// Add the filter | ||
add_filter('wl_jsonld_author', '_wl_jsonld_author__author_filter', 10, 2); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think
$references
would work as an output in this case.Check src/includes/class-wordlift-entity-post-to-jsonld-converter.php:L123 to see how we do it in a similar case: