From 32bac3560ca569be6fbbd58517aa10898e5d09c4 Mon Sep 17 00:00:00 2001 From: Zwifi Date: Tue, 2 Jul 2024 12:05:31 +0200 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Pete Edwards --- src/http/errorResponse.mock.ts | 2 +- src/http/problemDetails.mock.ts | 2 +- src/http/problemDetails.ts | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/http/errorResponse.mock.ts b/src/http/errorResponse.mock.ts index 6b69a6a..553097d 100644 --- a/src/http/errorResponse.mock.ts +++ b/src/http/errorResponse.mock.ts @@ -45,7 +45,7 @@ export function mockErrorResponse({ url: url === null ? undefined : url ?? "https://example.org/resource", headers: headers === null ? undefined : headers ?? new Headers(), }, - // The type assertion allows to create invalid error + // The type assertion allows us to create invalid error // responses for unit tests purpose. } as WithErrorResponse; } diff --git a/src/http/problemDetails.mock.ts b/src/http/problemDetails.mock.ts index 528d980..8b72338 100644 --- a/src/http/problemDetails.mock.ts +++ b/src/http/problemDetails.mock.ts @@ -42,7 +42,7 @@ export function mockProblemDetails({ detail, instance, }, - // The type assertion allows to null fields for unit tests. + // The type assertion allows us to null fields for unit tests. } as WithProblemDetails; } diff --git a/src/http/problemDetails.ts b/src/http/problemDetails.ts index 24ad3ab..085f33b 100644 --- a/src/http/problemDetails.ts +++ b/src/http/problemDetails.ts @@ -59,7 +59,7 @@ export type ProblemDetails = Readonly<{ */ detail?: string; /** - * A unique URL identifying the problem occurence. + * A unique URL identifying the problem occurrence. */ instance?: URL; }>;