SDK-3357: Add node 22 to matrix and set as default #1078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwardsph
had a problem deploying
to
ESS PodSpaces
GitHub Actions
Failure
edwardsph
temporarily deployed
to
ESS PodSpaces
GitHub Actions
Inactive
edwardsph
had a problem deploying
to
ESS PodSpaces
GitHub Actions
Error
edwardsph
had a problem deploying
to
ESS PodSpaces
GitHub Actions
Error
edwardsph
temporarily deployed
to
ESS PodSpaces
GitHub Actions
Inactive
edwardsph
temporarily deployed
to
ESS PodSpaces
GitHub Actions
Inactive
edwardsph
temporarily deployed
to
ESS PodSpaces
GitHub Actions
Inactive
NSeydoux
approved these changes
Aug 19, 2024
| @@ -26,7 +26,7 @@ jobs: | |||
| - uses: actions/checkout@v4 | |||
| - uses: actions/setup-node@v4 | |||
| with: | |||
| node-version: 20.x | |||
| node-version: 22.x | |||
There was a problem hiding this comment.
Here, the node version is only ever used to build, it's irrelevant to the tests. I suggest we change this to node-version-file: ".nvmrc", to avoid the churn.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New feature description
Added Node 22 support.