From e32a4f4ef9e6673d2accc7b5af10025576f2ea91 Mon Sep 17 00:00:00 2001 From: Zwifi Date: Thu, 19 Dec 2024 17:11:03 +0100 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Pete Edwards --- CHANGELOG.md | 2 +- src/gConsent/query/query.ts | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 42ef3129..8603378e 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,7 +7,7 @@ This project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html The following changes are pending, and will be applied on the next major release: - The `getAccessGrantAll` function is deprecated. It can be replaced with `query`. - Although the two functions behavior is different, they can be used to achieve + Although the two functions' behavior is different, they can be used to achieve similar results. - The `gConsent` and all of `gConsent/*` submodules are deprecated. The former can be replaced by a regular import of the library, and the latter can be replaced diff --git a/src/gConsent/query/query.ts b/src/gConsent/query/query.ts index 1cbd789e..f6f90d2e 100644 --- a/src/gConsent/query/query.ts +++ b/src/gConsent/query/query.ts @@ -160,7 +160,7 @@ function toCredentialFilter(url: URL): CredentialFilter { async function parseQueryResponse( responseJson: unknown, ): Promise { - // The type assertion here is immediatly checked. + // The type assertion here is immediately checked. const candidate = responseJson as { items: unknown }; if (candidate.items === undefined || !Array.isArray(candidate.items)) { throw new AccessGrantError( @@ -216,11 +216,11 @@ function toQueryUrl(endpoint: URL, filter: CredentialFilter): URL { } /** - * Query for Access Credential (Access Requests, Access Grants or Access Denials) based on a given filter. + * Query for Access Credentials (Access Requests, Access Grants or Access Denials) based on a given filter. * * @param filter The query filter * @param options Query options - * @returns a paginated set of matching the given filter + * @returns a paginated set of Access Credentials matching the given filter * @since unreleased * * @example