From 21dbc708a267b946eeb01b866bef524526f6e9d0 Mon Sep 17 00:00:00 2001
From: Nicolas Ayral Seydoux <nseydoux@inrupt.com>
Date: Mon, 9 Dec 2024 23:41:57 +0100
Subject: [PATCH] Improve getters unit tests

---
 src/common/getters.test.ts | 160 +++++++++++++++++++++++++++++++++++++
 1 file changed, 160 insertions(+)

diff --git a/src/common/getters.test.ts b/src/common/getters.test.ts
index 7cb05ca8..83194421 100644
--- a/src/common/getters.test.ts
+++ b/src/common/getters.test.ts
@@ -48,6 +48,9 @@ import {
   getCustomString,
   getTypes,
   getCustomIntegers,
+  getCustomBooleans,
+  getCustomDoubles,
+  getCustomStrings,
 } from "./getters";
 import type { AccessGrant, AccessRequest } from "../gConsent";
 import { TYPE, gc } from "./constants";
@@ -676,6 +679,163 @@ describe("getters", () => {
     });
   });
 
+  describe("getCustomBooleans", () => {
+    it("gets a boolean array value from an access request custom field", async () => {
+      const customFields = [
+        {
+          key: new URL("https://example.org/ns/customBoolean"),
+          value: [true],
+        },
+      ];
+      const gConsentRequest = await mockGConsentRequest({
+        custom: customFields,
+      });
+      // This shows the typing of the return is correct.
+      const b: boolean[] = getCustomBooleans(
+        gConsentRequest,
+        new URL("https://example.org/ns/customBoolean"),
+      );
+      expect(b).toEqual([true]);
+    });
+
+    it("throws on mixed types", async () => {
+      const customFields = [
+        {
+          key: new URL("https://example.org/ns/customBoolean"),
+          value: true,
+        },
+        {
+          key: new URL("https://example.org/ns/customBoolean"),
+          value: "not a boolean",
+        },
+      ];
+      const gConsentRequest = await mockGConsentRequest({
+        custom: customFields,
+      });
+      expect(() =>
+        getCustomBooleans(
+          gConsentRequest,
+          new URL("https://example.org/ns/customBoolean"),
+        ),
+      ).toThrow();
+    });
+
+    it("gets an empty value from an access request without custom field", async () => {
+      const gConsentRequest = await mockGConsentRequest();
+      // This shows the typing of the return is correct.
+      const b: boolean[] = getCustomBooleans(
+        gConsentRequest,
+        new URL("https://example.org/ns/customBoolean"),
+      );
+      expect(b).toHaveLength(0);
+    });
+  });
+
+  describe("getCustomDoubles", () => {
+    it("gets a double array value from an access request custom field", async () => {
+      const customFields = [
+        {
+          key: new URL("https://example.org/ns/customDouble"),
+          value: [1.1],
+        },
+      ];
+      const gConsentRequest = await mockGConsentRequest({
+        custom: customFields,
+      });
+      // This shows the typing of the return is correct.
+      const d: number[] = getCustomDoubles(
+        gConsentRequest,
+        new URL("https://example.org/ns/customDouble"),
+      );
+      expect(d).toEqual([1.1]);
+    });
+
+    it("throws on mixed types", async () => {
+      const customFields = [
+        {
+          key: new URL("https://example.org/ns/customDouble"),
+          value: 1.1,
+        },
+        {
+          key: new URL("https://example.org/ns/customDouble"),
+          value: "not a double",
+        },
+      ];
+      const gConsentRequest = await mockGConsentRequest({
+        custom: customFields,
+      });
+      expect(() =>
+        getCustomDoubles(
+          gConsentRequest,
+          new URL("https://example.org/ns/customDouble"),
+        ),
+      ).toThrow();
+    });
+
+    it("gets an empty value from an access request without custom field", async () => {
+      const gConsentRequest = await mockGConsentRequest();
+      // This shows the typing of the return is correct.
+      const d: number[] = getCustomDoubles(
+        gConsentRequest,
+        new URL("https://example.org/ns/customDouble"),
+      );
+      expect(d).toHaveLength(0);
+    });
+  });
+
+  describe("getCustomStrings", () => {
+    it("gets a string array value from an access request custom field", async () => {
+      const customFields = [
+        {
+          key: new URL("https://example.org/ns/customString"),
+          value: ["custom value"],
+        },
+      ];
+      const gConsentRequest = await mockGConsentRequest({
+        custom: customFields,
+      });
+      // This shows the typing of the return is correct.
+      const s: string[] = getCustomStrings(
+        gConsentRequest,
+        new URL("https://example.org/ns/customString"),
+      );
+      expect(s).toEqual(["custom value"]);
+    });
+
+    it("throws on mixed types", async () => {
+      const customFields = [
+        {
+          key: new URL("https://example.org/ns/customString"),
+          value: "some value",
+        },
+        {
+          key: new URL("https://example.org/ns/customString"),
+          // Not a string
+          value: false,
+        },
+      ];
+      const gConsentRequest = await mockGConsentRequest({
+        custom: customFields,
+      });
+      expect(() =>
+        getCustomDoubles(
+          gConsentRequest,
+          new URL("https://example.org/ns/customString"),
+        ),
+      ).toThrow();
+    });
+
+    it("gets an empty value from an access request without custom field", async () => {
+      const gConsentRequest = await mockGConsentRequest();
+      // This shows the typing of the return is correct.
+      const s: string[] = getCustomStrings(
+        gConsentRequest,
+        new URL("https://example.org/ns/customString"),
+      );
+      expect(s).toHaveLength(0);
+    });
+  });
+
   describe("getCustomInteger", () => {
     it("gets an integer value from an access request custom field", async () => {
       const customFields = [