Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: retry button on transfaction failure should check old firmware error for ledger #961

Merged
merged 7 commits into from
May 1, 2024
Merged

fix: retry button on transfaction failure should check old firmware error for ledger #961

merged 7 commits into from
May 1, 2024

Conversation

AngelCastilloB
Copy link
Member

The retry button on the transaction failure doesnt not follow the same validations that the stack confirmation modal

Checklist

  • JIRA - <link>
  • Proper tests implemented
  • Screenshots added.

Proposed solution

Make the MULTIDELEGATION_NOT_SUPPORTED validations on the TransactionFail modal

Screenshots

Attach screenshots here if implementation involves some UI changes

@AngelCastilloB AngelCastilloB requested a review from a team as a code owner March 18, 2024 08:46
@github-actions github-actions bot added the staking Changes to the staking package. label Mar 18, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 18, 2024 •
edited
Loading

Allure report

allure-report-publisher generated test report!

smokeTests: ✅ test report for 69e82912

passed failed skipped flaky total result
Total 30 0 0 0 30 ✅

DominikGuzei
DominikGuzei approved these changes Mar 18, 2024
View reviewed changes
Copy link
Member

@DominikGuzei DominikGuzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢 just left some minor suggestions

@coveralls
Copy link

coveralls commented Mar 18, 2024 •
edited
Loading

Coverage Status

coverage: 50.56%. remained the same
when pulling 971761c on fix/lw-9912-fix-old-firmware-multidelegation-defect
into 1045749 on main.

@AngelCastilloB AngelCastilloB force-pushed the fix/lw-9912-fix-old-firmware-multidelegation-defect branch from f23af8d to 7024c26 Compare March 18, 2024 10:50
@mkazlauskas mkazlauskas requested a review from a team March 19, 2024 07:44
@tomislavhoracek tomislavhoracek self-requested a review March 19, 2024 12:29
tomislavhoracek
tomislavhoracek approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@tomislavhoracek tomislavhoracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AngelCastilloB 🚀

@tomislavhoracek tomislavhoracek force-pushed the fix/lw-9912-fix-old-firmware-multidelegation-defect branch from 488e465 to 5ad118c Compare March 29, 2024 08:51
@github-actions github-actions bot removed the staking Changes to the staking package. label Mar 29, 2024
@tomislavhoracek tomislavhoracek added the staking Changes to the staking package. label Mar 29, 2024
@tomislavhoracek tomislavhoracek force-pushed the fix/lw-9912-fix-old-firmware-multidelegation-defect branch from 5ad118c to 5178925 Compare April 3, 2024 08:05
@github-actions github-actions bot removed the staking Changes to the staking package. label Apr 3, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@tomislavhoracek tomislavhoracek merged commit 00f0c52 into main May 1, 2024
12 checks passed
@tomislavhoracek tomislavhoracek deleted the fix/lw-9912-fix-old-firmware-multidelegation-defect branch May 1, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DominikGuzei DominikGuzei DominikGuzei approved these changes

@tomislavhoracek tomislavhoracek tomislavhoracek approved these changes

Assignees

@AngelCastilloB AngelCastilloB

@tomislavhoracek tomislavhoracek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@AngelCastilloB @coveralls @DominikGuzei @tomislavhoracek @rhyslbw @pczeglik-iohk