Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: e2e - fix/tag failing tests (maintenance) #1587

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

ljagiela
Copy link
Contributor

No description provided.

Copy link

sonarcloud bot commented Dec 11, 2024

Copy link
Contributor

@mirceahasegan mirceahasegan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

@@ -14,10 +14,7 @@ class MessageSigningAllDoneDrawerAssert {
await MessageSigningAllDoneDrawer.image.waitForDisplayed();
await MessageSigningAllDoneDrawer.title.waitForDisplayed();
expect(await MessageSigningAllDoneDrawer.title.getText()).to.equal(await t('core.signMessage.successTitle'));
await MessageSigningAllDoneDrawer.description.waitForDisplayed();
expect(await MessageSigningAllDoneDrawer.description.getText()).to.equal(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because description was removed from UI?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct, it's expected

@pczeglik-iohk
Copy link
Contributor

Allure Report

allure-report-publisher generated test report!

processReports: ✅ test report for e6dc85ee

passed failed skipped flaky total result
Total 33 0 4 0 37

@ljagiela ljagiela merged commit 379e9f1 into main Dec 11, 2024
30 checks passed
@ljagiela ljagiela deleted the test/test_maintenance_11_Dec branch December 11, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants