feat: export json in activity detail #1331
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allure Report
smokeTests: ✅ test report for 5883050a
processReports: ✅ test report for a76f8fac
|
greatertomi
approved these changes
Jul 29, 2024
danielmain
approved these changes
Jul 30, 2024
| @@ -95,6 +101,11 @@ export const SharedWalletTransactionDetailsWrapper = withAddressBookContext( | |||
| [addressToNameMap, amountTransformer, cardanoCoin, txSummary] | |||
There was a problem hiding this comment.
Don't you also need coSigners to be watched for changes?
Suggested change
| [addressToNameMap, amountTransformer, cardanoCoin, txSummary] | |
| [addressToNameMap, amountTransformer, cardanoCoin, txSummary, coSigners] |
There was a problem hiding this comment.
Resolved in slack.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Proposed solution
Add option to download tx file in acitvity detail.
Testing
Describe here, how the new implementation can be tested.
Provide link or briefly describe User Acceptance Criteria/Tests that need to be met
Screenshots