-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add custom submit endpoint option #1000
feat: add custom submit endpoint option #1000
Conversation
15f14c6
to
28a4756
Compare
Allure report
smokeTests: ✅ test report for 573bdaee
|
0d41cfa
to
315a020
Compare
c9f3341
to
4272b93
Compare
...r-extension-wallet/src/views/browser-view/features/send-transaction/components/Form/Form.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a small comment.
@greatertomi Please update the PR description 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GJ!
...r-extension-wallet/src/views/browser-view/features/send-transaction/components/Form/Form.tsx
Outdated
Show resolved
Hide resolved
...tension-wallet/src/views/browser-view/features/settings/components/CustomSubmitApiDrawer.tsx
Outdated
Show resolved
Hide resolved
...tension-wallet/src/views/browser-view/features/settings/components/CustomSubmitApiDrawer.tsx
Outdated
Show resolved
Hide resolved
...tension-wallet/src/views/browser-view/features/settings/components/CustomSubmitApiDrawer.tsx
Outdated
Show resolved
Hide resolved
...tension-wallet/src/views/browser-view/features/settings/components/CustomSubmitApiDrawer.tsx
Outdated
Show resolved
Hide resolved
...tension-wallet/src/views/browser-view/features/settings/components/CustomSubmitApiDrawer.tsx
Outdated
Show resolved
Hide resolved
4272b93
to
d22cd77
Compare
...tension-wallet/src/views/browser-view/features/settings/components/CustomSubmitApiDrawer.tsx
Show resolved
Hide resolved
Did we think about whether the custom node submission should be set for lace globally (all restored wallets) or per specific wallet? |
...tension-wallet/src/views/browser-view/features/settings/components/CustomSubmitApiDrawer.tsx
Outdated
Show resolved
Hide resolved
...tension-wallet/src/views/browser-view/features/settings/components/CustomSubmitApiDrawer.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GJ!
.../views/browser-view/components/CustomSubmitApiWarningBanner/CustomSubmitApiWarningBanner.tsx
Outdated
Show resolved
Hide resolved
...xtension-wallet/src/components/CustomSubmitApiWarningBanner/CustomSubmitApiWarningBanner.tsx
Outdated
Show resolved
Hide resolved
...tension-wallet/src/views/browser-view/features/staking/components/MultiDelegationStaking.tsx
Outdated
Show resolved
Hide resolved
...tension-wallet/src/views/browser-view/features/staking/components/MultiDelegationStaking.tsx
Outdated
Show resolved
Hide resolved
41699ef
to
f50ad1c
Compare
624a11a
to
ffa9d2c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested it on preview and everything works as expected.
b38d20a
to
573bdae
Compare
Quality Gate passedIssues Measures |
Checklist
Proposed solution
This PR adds the ability to submit transaction to a submit tx endpoint running in a local node.
Testing
Describe here, how the new implementation can be tested.
Provide link or briefly describe User Acceptance Criteria/Tests that need to be met
Screenshots