Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add custom submit endpoint option #1000

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

greatertomi
Copy link
Contributor

@greatertomi greatertomi commented Mar 27, 2024

Checklist

  • JIRA - LW-10025, LW-10052, LW-10121
  • Proper tests implemented
  • Screenshots added.

Proposed solution

This PR adds the ability to submit transaction to a submit tx endpoint running in a local node.

Testing

Describe here, how the new implementation can be tested.
Provide link or briefly describe User Acceptance Criteria/Tests that need to be met

Screenshots

Screenshot 2024-04-08 at 15 25 36 Screenshot 2024-04-17 at 17 20 08 Screenshot 2024-04-08 at 15 29 25 Screenshot 2024-04-17 at 17 38 59

@greatertomi greatertomi force-pushed the feat/LW-10025-add-custom-submit-endpoint-option branch from 15f14c6 to 28a4756 Compare March 27, 2024 16:39
Copy link

github-actions bot commented Mar 27, 2024

Allure report

allure-report-publisher generated test report!

smokeTests: ✅ test report for 573bdaee

passed failed skipped flaky total result
Total 27 0 0 0 27

@greatertomi greatertomi force-pushed the feat/LW-10025-add-custom-submit-endpoint-option branch 5 times, most recently from 0d41cfa to 315a020 Compare April 4, 2024 12:19
@greatertomi greatertomi marked this pull request as ready for review April 4, 2024 12:44
@greatertomi greatertomi requested a review from a team as a code owner April 4, 2024 12:44
@greatertomi greatertomi force-pushed the feat/LW-10025-add-custom-submit-endpoint-option branch from c9f3341 to 4272b93 Compare April 4, 2024 16:31
Copy link
Contributor

@shawnbusuttil shawnbusuttil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a small comment.

@szymonmaslowski
Copy link
Contributor

@greatertomi Please update the PR description 🙏

Copy link
Contributor

@szymonmaslowski szymonmaslowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ!

@greatertomi greatertomi force-pushed the feat/LW-10025-add-custom-submit-endpoint-option branch from 4272b93 to d22cd77 Compare April 9, 2024 11:47
@szymonmaslowski
Copy link
Contributor

Did we think about whether the custom node submission should be set for lace globally (all restored wallets) or per specific wallet?

Copy link
Contributor

@shawnbusuttil shawnbusuttil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@szymonmaslowski szymonmaslowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ!

apps/browser-extension-wallet/webpack-utils.js Outdated Show resolved Hide resolved
@greatertomi greatertomi force-pushed the feat/LW-10025-add-custom-submit-endpoint-option branch 2 times, most recently from 41699ef to f50ad1c Compare April 22, 2024 12:57
@greatertomi greatertomi force-pushed the feat/LW-10025-add-custom-submit-endpoint-option branch 2 times, most recently from 624a11a to ffa9d2c Compare April 23, 2024 08:33
Copy link
Contributor

@emiride emiride left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it on preview and everything works as expected.

@greatertomi greatertomi force-pushed the feat/LW-10025-add-custom-submit-endpoint-option branch from b38d20a to 573bdae Compare April 24, 2024 17:10
Copy link

sonarcloud bot commented Apr 24, 2024

@greatertomi greatertomi merged commit 68009be into main Apr 24, 2024
11 of 12 checks passed
@greatertomi greatertomi deleted the feat/LW-10025-add-custom-submit-endpoint-option branch April 24, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants