Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tryReadTBQueueDefault: fix bug when returning Nothing #196

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

amesgen
Copy link
Member

@amesgen amesgen commented Dec 7, 2024

Closes #195

AFAICT, there is no need to update the state of the TBQueue when we didn't read anything.

Copy link
Collaborator

@coot coot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Alex, LGTM

@coot
Copy link
Collaborator

coot commented Dec 10, 2024

If you need it in 1.5.x we can release 1.5.1.1 version.

@amesgen amesgen force-pushed the amesgen/tryReadTBQueue branch from e349d6d to f7c943c Compare December 10, 2024 17:19
@amesgen
Copy link
Member Author

amesgen commented Dec 10, 2024

If you need it in 1.5.x we can release 1.5.1.1 version.

I think it would be neat if it is not too much work, but it is not urgent for IOG stuff as one can work around this (I am also out of office until next year).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tryReadTBQueue is buggy in IOSim
2 participants