Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package..ghcOptions should be sent to the haddock command #2129

Open
pranaysashank opened this issue Dec 17, 2023 · 1 comment
Open

package..ghcOptions should be sent to the haddock command #2129

pranaysashank opened this issue Dec 17, 2023 · 1 comment
Labels
bug Something isn't working preserved Keep stale bot away

Comments

@pranaysashank
Copy link

Describe the bug

package..ghcOptions are not sent to haddock

Steps To Reproduce

  1. Add -XDuplicateRecordFields to a package that requires it in ghcOptions
  2. Build the haddock derivation (via nix-shell), haddock build fails because it doesn't have the DuplicateRecordFields extension enabled.

Expected behavior

ghcOptions gets passed to haddock via --optghc

Additional context

I faced this issue when upgrading to 9.8.1, a few packages that were building fine before now require DuplicateRecordFields behaviour with a warning that the behaviour will be deprecated in the future. As a temporary fix, I passed the ghcOptions in the module settings for the package (amazonka). This builds fine, but haddock building fails. I set doHaddock = false for the package as part of the temporary fix

  • Build system (eg. x86_64-linux or aarch64-darwin): x86)64-linux
  • GHC version: 9.8.1
  • Haskell.nix version (or commit) used: 1536b63
@pranaysashank pranaysashank added the bug Something isn't working label Dec 17, 2023
Copy link

stale bot commented Apr 16, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Apr 16, 2024
@hamishmack hamishmack added the preserved Keep stale bot away label May 14, 2024
@stale stale bot removed the wontfix label May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working preserved Keep stale bot away
Projects
None yet
Development

No branches or pull requests

2 participants