Fix the infinitely looping Errors shrinker
#84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorisdral
force-pushed
the
jdral/fix-errors-shrink
branch
from
dbc9f07 to
6b8b653
Compare
When `Errors` are empty (`allNull`) and we start shrinking, the shrinker will loop forever. The cause lies in the `genInfinite` function for `Stream`s, which generates a finite list even though it is marked as infinite. The next commit introduces a minimal bug fix.
jorisdral
force-pushed
the
jdral/fix-errors-shrink
branch
from
288b0c2 to
5170704
Compare
This makes the `prop_regression_shrinkEmptyErrors` property succeed, and not loop forever during shrinking.
jorisdral
force-pushed
the
jdral/fix-errors-shrink
branch
from
5170704 to
2c89665
Compare
jasagredo
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the commit messages for an explanation