Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge HasBufFS into HasFS #61

Merged
merged 1 commit into from
May 3, 2024
Merged

Conversation

jorisdral
Copy link
Collaborator

No description provided.

@jorisdral jorisdral requested a review from a team as a code owner May 3, 2024 08:24
@jorisdral jorisdral self-assigned this May 3, 2024
@jorisdral jorisdral force-pushed the jdral/merge-hasbuffs-into-hasfs branch 2 times, most recently from a7233cc to 6c5752e Compare May 3, 2024 08:56
@@ -30,7 +30,6 @@ library
System.FS.Sim.Error
System.FS.Sim.FsTree
System.FS.Sim.MockFS
System.FS.Sim.Pure
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My thinking here is that we can safely remove this module and refrain from exposing System.FS.Sim.Prim because these modules are not currently used by ouroboros-consensus or lsm-tree. It's more useful for those packages to use simHasFS or simErrorHasFS instead. However, if in the future there would be a request to expose parts of the System.FS.Sim.Prim module, we can do that then. For now, I'm in favour of applying the YAGNI principle

Copy link
Contributor

@jasagredo jasagredo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps it already exists and I didn't notice, but I think it would be useful to have a list somewhere with the 3-4 types of FSs this library exposes and when to use one or the other.

fs-api/src/System/FS/API.hs Outdated Show resolved Hide resolved
fs-api/src/System/FS/IO.hs Show resolved Hide resolved
@jorisdral
Copy link
Collaborator Author

Perhaps it already exists and I didn't notice, but I think it would be useful to have a list somewhere with the 3-4 types of FSs this library exposes and when to use one or the other.

The fs-api README and fs-sim README mention the available ones. That also reminds me that I should update those to account for the now removed pureHasFS!

@jorisdral jorisdral force-pushed the jdral/merge-hasbuffs-into-hasfs branch from 6c5752e to ec7c42d Compare May 3, 2024 12:19
Copy link
Contributor

@jasagredo jasagredo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jorisdral jorisdral enabled auto-merge May 3, 2024 12:22
@jorisdral jorisdral added this pull request to the merge queue May 3, 2024
Merged via the queue into main with commit a25d399 May 3, 2024
18 checks passed
@jorisdral jorisdral deleted the jdral/merge-hasbuffs-into-hasfs branch May 3, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants