-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge HasBufFS
into HasFS
#61
Conversation
a7233cc
to
6c5752e
Compare
@@ -30,7 +30,6 @@ library | |||
System.FS.Sim.Error | |||
System.FS.Sim.FsTree | |||
System.FS.Sim.MockFS | |||
System.FS.Sim.Pure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My thinking here is that we can safely remove this module and refrain from exposing System.FS.Sim.Prim
because these modules are not currently used by ouroboros-consensus
or lsm-tree
. It's more useful for those packages to use simHasFS
or simErrorHasFS
instead. However, if in the future there would be a request to expose parts of the System.FS.Sim.Prim
module, we can do that then. For now, I'm in favour of applying the YAGNI principle
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps it already exists and I didn't notice, but I think it would be useful to have a list somewhere with the 3-4 types of FSs this library exposes and when to use one or the other.
The |
6c5752e
to
ec7c42d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
No description provided.