Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(Reddit - Remove subreddit dialog): Patch fails on older versions #2688

Open
7 tasks done
KobeW50 opened this issue Jan 16, 2025 · 2 comments
Open
7 tasks done

bug(Reddit - Remove subreddit dialog): Patch fails on older versions #2688

KobeW50 opened this issue Jan 16, 2025 · 2 comments
Labels
Bug report Something isn't working

Comments

@KobeW50
Copy link
Contributor

KobeW50 commented Jan 16, 2025 •
edited
Loading

Type

Error while patching

Tools used

RVX Manager

Application

RVX Manager 1.23.5

Reddit 2024.20.2 and 2024.29.0

2024.20.2 apkmirror.com link
2024.29.0 apkmirror.com link

Bug description

The fingerprint fails to be resolved on both versions. In 2024.20.2, the patching fails completely and no apk is produced, whereas in 2024.29.0 the patching ends up producing an apk despite the error.

Error logs (2024.20.2)

- Device Info
RVX Manager: 1.23.5
Model: SM-S906U1
Android version: 14
Supported architectures: arm64-v8a, armeabi-v7a, armeabi
Root permissions: No

- Patch Info
App: com.reddit.frontpage v2024.20.2 (Suggested: Any)
Patches version: v5.2.2
Patches added: Default
Patches removed: None
Default patch options changed: None

- Settings
Allow changing patch selection: true
Version compatibility check: true
Show universal patches: false
Remove unused library: false
Use pre-release: false
Patches source: inotia00/revanced-patches

- Logs
Reading APK
Decoding app manifest
Loading patches
Deleting existing temporary files directory
Decoding resources
Initializing lookup maps
Executing patches
Applied 10 patches
Remove subreddit dialog failed: app.revanced.patcher.patch.PatchException: Failed to resolve frequentUpdatesSheetV2ScreenInvokeFingerprint
	at app.revanced.util.fingerprint.LegacyFingerprintKt.getException(LegacyFingerprint.kt:24)
	at app.revanced.util.fingerprint.LegacyFingerprintKt.methodOrThrow(LegacyFingerprint.kt:64)
	at app.revanced.patches.reddit.layout.subredditdialog.SubRedditDialogPatchKt.subRedditDialogPatch$lambda$7$lambda$6(SubRedditDialogPatch.kt:51)
	at app.revanced.patches.reddit.layout.subredditdialog.SubRedditDialogPatchKt.$r8$lambda$58F9r0gtWVsPXia7ypDQbvEpzEA(Unknown Source:0)
	at app.revanced.patches.reddit.layout.subredditdialog.SubRedditDialogPatchKt$$ExternalSyntheticLambda0.invoke(Unknown Source:2)
	at app.revanced.patcher.patch.Patch.execute(SourceFile:71)
	at app.revanced.patcher.patch.BytecodePatch.execute$revanced_patcher(SourceFile:166)
	at app.revanced.patcher.Patcher$invoke$1.invokeSuspend$execute(SourceFile:84)
	at app.revanced.patcher.Patcher$invoke$1.invokeSuspend(SourceFile:109)
	at app.revanced.patcher.Patcher$invoke$1.invoke(SourceFile:0)
	at app.revanced.patcher.Patcher$invoke$1.invoke(SourceFile:0)
	at kotlinx.coroutines.flow.SafeFlow.collectSafely(SourceFile:57)
	at kotlinx.coroutines.flow.AbstractFlow.collect(SourceFile:226)
	at app.revanced.manager.flutter.MainActivity$runPatcher$1$patcherResult$1$1.invokeSuspend(SourceFile:323)
	at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(SourceFile:33)
	at kotlinx.coroutines.DispatchedTask.run(SourceFile:101)
	at kotlinx.coroutines.EventLoopImplBase.processNextEvent(SourceFile:263)
	at kotlinx.coroutines.BlockingCoroutine.joinBlocking(SourceFile:95)
	at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking(SourceFile:69)
	at kotlinx.coroutines.BuildersKt.runBlocking(SourceFile:1)
	at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking$default(SourceFile:47)
	at kotlinx.coroutines.BuildersKt.runBlocking$default(SourceFile:1)
	at app.revanced.manager.flutter.MainActivity.runPatcher$lambda$34(SourceFile:317)
	at app.revanced.manager.flutter.MainActivity.$r8$lambda$Oku38Rh6VOg9CiulxEElyw3q4GI(SourceFile:0)
	at app.revanced.manager.flutter.MainActivity$$ExternalSyntheticLambda0.run(SourceFile:0)
	at java.lang.Thread.run(Thread.java:1012)
Compiling modified resources
An error occurred:
brut.androlib.exceptions.AndrolibException: brut.common.BrutException: could not exec (exit code = 1): [/data/app/~~6CdHxoOFyNy52nVncBabRQ==/app.rvx.manager.flutter-7YJg3s_aUvBlUoDcmr1i-g==/lib/arm64/libaapt2.so, link, -o, /data/user/0/app.rvx.manager.flutter/files/patcher/tmp-XHRFEO/revanced-temporary-files/patched/resources/resources.apk, --package-id, 127, --min-sdk-version, 26, --target-sdk-version, 34, --version-code, 1624969, --version-name, 2024.20.2, --no-auto-version, --no-version-vectors, --no-version-transitions, --no-resource-deduping, --allow-reserved-package-id, --warn-manifest-validation, -e, /data/user/0/app.rvx.manager.flutter/cache/APKTOOL4538971608276109827.tmp, -0, arsc, -I, /data/user/0/app.rvx.manager.flutter/files/patcher/tmp-XHRFEO/revanced-temporary-files/1.apk, --manifest, /data/user/0/app.rvx.manager.flutter/files/patcher/tmp-XHRFEO/revanced-temporary-files/apk/AndroidManifest.xml, /data/user/0/app.rvx.manager.flutter/files/patcher/tmp-XHRFEO/revanced-temporary-files/apk/build/resources.zip]
	at brut.androlib.AaptInvoker.invokeAapt2(SourceFile:249)
	at brut.androlib.AaptInvoker.invokeAapt(SourceFile:394)
	at app.revanced.patcher.patch.ResourcePatchContext.get(SourceFile:133)
	at app.revanced.patcher.Patcher.get(SourceFile:159)
	at app.revanced.manager.flutter.MainActivity.runPatcher$lambda$34(SourceFile:342)
	at app.revanced.manager.flutter.MainActivity.$r8$lambda$Oku38Rh6VOg9CiulxEElyw3q4GI(SourceFile:0)
	at app.revanced.manager.flutter.MainActivity$$ExternalSyntheticLambda0.run(SourceFile:0)
	at java.lang.Thread.run(Thread.java:1012)
Caused by: brut.common.BrutException: could not exec (exit code = 1): [/data/app/~~6CdHxoOFyNy52nVncBabRQ==/app.rvx.manager.flutter-7YJg3s_aUvBlUoDcmr1i-g==/lib/arm64/libaapt2.so, link, -o, /data/user/0/app.rvx.manager.flutter/files/patcher/tmp-XHRFEO/revanced-temporary-files/patched/resources/resources.apk, --package-id, 127, --min-sdk-version, 26, --target-sdk-version, 34, --version-code, 1624969, --version-name, 2024.20.2, --no-auto-version, --no-version-vectors, --no-version-transitions, --no-resource-deduping, --allow-reserved-package-id, --warn-manifest-validation, -e, /data/user/0/app.rvx.manager.flutter/cache/APKTOOL4538971608276109827.tmp, -0, arsc, -I, /data/user/0/app.rvx.manager.flutter/files/patcher/tmp-XHRFEO/revanced-temporary-files/1.apk, --manifest, /data/user/0/app.rvx.manager.flutter/files/patcher/tmp-XHRFEO/revanced-temporary-files/apk/AndroidManifest.xml, /data/user/0/app.rvx.manager.flutter/files/patcher/tmp-XHRFEO/revanced-temporary-files/apk/build/resources.zip]
	at brut.util.OS.exec(SourceFile:104)
	at brut.androlib.AaptInvoker.invokeAapt2(SourceFile:245)
	... 7 more

Error logs (2024.29.0)

- Device Info
RVX Manager: 1.23.5
Model: SM-S906U1
Android version: 14
Supported architectures: arm64-v8a, armeabi-v7a, armeabi
Root permissions: No

- Patch Info
App: com.reddit.frontpage v2024.29.0 (Suggested: Any)
Patches version: v5.2.2
Patches added: Default
Patches removed: None
Default patch options changed: None

- Settings
Allow changing patch selection: true
Version compatibility check: true
Show universal patches: false
Remove unused library: false
Use pre-release: false
Patches source: inotia00/revanced-patches

- Logs
Reading APK
Decoding app manifest
Loading patches
Deleting existing temporary files directory
Decoding resources
Initializing lookup maps
Executing patches
Applied 10 patches
Remove subreddit dialog failed: app.revanced.patcher.patch.PatchException: Failed to resolve frequentUpdatesSheetV2ScreenInvokeFingerprint
	at app.revanced.util.fingerprint.LegacyFingerprintKt.getException(LegacyFingerprint.kt:24)
	at app.revanced.util.fingerprint.LegacyFingerprintKt.methodOrThrow(LegacyFingerprint.kt:64)
	at app.revanced.patches.reddit.layout.subredditdialog.SubRedditDialogPatchKt.subRedditDialogPatch$lambda$7$lambda$6(SubRedditDialogPatch.kt:51)
	at app.revanced.patches.reddit.layout.subredditdialog.SubRedditDialogPatchKt.$r8$lambda$58F9r0gtWVsPXia7ypDQbvEpzEA(Unknown Source:0)
	at app.revanced.patches.reddit.layout.subredditdialog.SubRedditDialogPatchKt$$ExternalSyntheticLambda0.invoke(Unknown Source:2)
	at app.revanced.patcher.patch.Patch.execute(SourceFile:71)
	at app.revanced.patcher.patch.BytecodePatch.execute$revanced_patcher(SourceFile:166)
	at app.revanced.patcher.Patcher$invoke$1.invokeSuspend$execute(SourceFile:84)
	at app.revanced.patcher.Patcher$invoke$1.invokeSuspend(SourceFile:109)
	at app.revanced.patcher.Patcher$invoke$1.invoke(SourceFile:0)
	at app.revanced.patcher.Patcher$invoke$1.invoke(SourceFile:0)
	at kotlinx.coroutines.flow.SafeFlow.collectSafely(SourceFile:57)
	at kotlinx.coroutines.flow.AbstractFlow.collect(SourceFile:226)
	at app.revanced.manager.flutter.MainActivity$runPatcher$1$patcherResult$1$1.invokeSuspend(SourceFile:323)
	at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(SourceFile:33)
	at kotlinx.coroutines.DispatchedTask.run(SourceFile:101)
	at kotlinx.coroutines.EventLoopImplBase.processNextEvent(SourceFile:263)
	at kotlinx.coroutines.BlockingCoroutine.joinBlocking(SourceFile:95)
	at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking(SourceFile:69)
	at kotlinx.coroutines.BuildersKt.runBlocking(SourceFile:1)
	at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking$default(SourceFile:47)
	at kotlinx.coroutines.BuildersKt.runBlocking$default(SourceFile:1)
	at app.revanced.manager.flutter.MainActivity.runPatcher$lambda$34(SourceFile:317)
	at app.revanced.manager.flutter.MainActivity.$r8$lambda$Oku38Rh6VOg9CiulxEElyw3q4GI(SourceFile:0)
	at app.revanced.manager.flutter.MainActivity$$ExternalSyntheticLambda0.run(SourceFile:0)
	at java.lang.Thread.run(Thread.java:1012)
Compiling modified resources
Aligning APK
Signing APK
Patched APK

Additional context

These Reddit version have significance: 2024.20.2 is the latest nodpi APK for Android 8+ available on apkmirror, and 2024.29.0 is the latest nodpi APK on apkmirror in general. Versions newer newer than 2024.29.0 require an anti-split tool in order to be patched with the RVX Manager

Device Environment

Android 14
OneUI 6.1
Non-root

Acknowledgements

  • This issue does not reproduce on unpatched YouTube or YT Music.
  • This issue is not a duplicate of an existing bug report.
  • I did not use any settings marked as Experimental Flags.
  • I have patched the APK according to the documentation.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
  • I have written the title and contents in English.
@KobeW50 KobeW50 added the Bug report Something isn't working label Jan 16, 2025
@KobeW50 KobeW50 changed the title bug(Reddit - Remove subreddit dialog): Patch fails on 2024.20.2 bug(Reddit - Remove subreddit dialog): Patch fails on 2024.20.2 and 2024.29.0 Jan 16, 2025
@inotia00 inotia00 changed the title bug(Reddit - Remove subreddit dialog): Patch fails on 2024.20.2 and 2024.29.0 bug(Reddit - Remove subreddit dialog): Patch fails on older versions Jan 17, 2025
@inotia00
Copy link
Owner

The versions supported by the patch are Reddit 2024.17.0 and Reddit 2024.29.0+

(Reddit 2024.18.0 ~ Reddit 2024.28.0 have resource obfuscation applied, so they can only be patched via ARSCLib)

inotia00 added a commit to inotia00/revanced-patches that referenced this issue Jan 17, 2025
@inotia00
fix(Reddit - Remove subreddit dialog): Patch fails on older versions i…
8118df8 
…notia00/ReVanced_Extended#2688
@KobeW50
Copy link
Contributor Author

KobeW50 commented Jan 17, 2025

The versions supported by the patch are Reddit 2024.17.0 and Reddit 2024.29.0+

It also fails on 2024.17.0

- Device Info
RVX Manager: 1.23.5
Model: SM-S906U1
Android version: 14
Supported architectures: arm64-v8a, armeabi-v7a, armeabi
Root permissions: No

- Patch Info
App: com.reddit.frontpage v2024.17.0 (Suggested: Any)
Patches version: v5.2.2
Patches added: Default
Patches removed: None
Default patch options changed: None

- Settings
Allow changing patch selection: true
Version compatibility check: true
Show universal patches: false
Remove unused library: false
Use pre-release: false
Patches source: inotia00/revanced-patches

- Logs
Reading APK
Decoding app manifest
Loading patches
Deleting existing temporary files directory
Decoding resources
Initializing lookup maps
Executing patches
Applied 10 patches
Remove subreddit dialog failed: app.revanced.patcher.patch.PatchException: Failed to resolve frequentUpdatesSheetV2ScreenInvokeFingerprint
	at app.revanced.util.fingerprint.LegacyFingerprintKt.getException(LegacyFingerprint.kt:24)
	at app.revanced.util.fingerprint.LegacyFingerprintKt.methodOrThrow(LegacyFingerprint.kt:64)
	at app.revanced.patches.reddit.layout.subredditdialog.SubRedditDialogPatchKt.subRedditDialogPatch$lambda$7$lambda$6(SubRedditDialogPatch.kt:51)
	at app.revanced.patches.reddit.layout.subredditdialog.SubRedditDialogPatchKt.$r8$lambda$58F9r0gtWVsPXia7ypDQbvEpzEA(Unknown Source:0)
	at app.revanced.patches.reddit.layout.subredditdialog.SubRedditDialogPatchKt$$ExternalSyntheticLambda0.invoke(Unknown Source:2)
	at app.revanced.patcher.patch.Patch.execute(SourceFile:71)
	at app.revanced.patcher.patch.BytecodePatch.execute$revanced_patcher(SourceFile:166)
	at app.revanced.patcher.Patcher$invoke$1.invokeSuspend$execute(SourceFile:84)
	at app.revanced.patcher.Patcher$invoke$1.invokeSuspend(SourceFile:109)
	at app.revanced.patcher.Patcher$invoke$1.invoke(SourceFile:0)
	at app.revanced.patcher.Patcher$invoke$1.invoke(SourceFile:0)
	at kotlinx.coroutines.flow.SafeFlow.collectSafely(SourceFile:57)
	at kotlinx.coroutines.flow.AbstractFlow.collect(SourceFile:226)
	at app.revanced.manager.flutter.MainActivity$runPatcher$1$patcherResult$1$1.invokeSuspend(SourceFile:323)
	at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(SourceFile:33)
	at kotlinx.coroutines.DispatchedTask.run(SourceFile:101)
	at kotlinx.coroutines.EventLoopImplBase.processNextEvent(SourceFile:263)
	at kotlinx.coroutines.BlockingCoroutine.joinBlocking(SourceFile:95)
	at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking(SourceFile:69)
	at kotlinx.coroutines.BuildersKt.runBlocking(SourceFile:1)
	at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking$default(SourceFile:47)
	at kotlinx.coroutines.BuildersKt.runBlocking$default(SourceFile:1)
	at app.revanced.manager.flutter.MainActivity.runPatcher$lambda$34(SourceFile:317)
	at app.revanced.manager.flutter.MainActivity.$r8$lambda$Oku38Rh6VOg9CiulxEElyw3q4GI(SourceFile:0)
	at app.revanced.manager.flutter.MainActivity$$ExternalSyntheticLambda0.run(SourceFile:0)
	at java.lang.Thread.run(Thread.java:1012)
Compiling modified resources
Aligning APK
Signing APK
Patched APK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug report Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@KobeW50 @inotia00